Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(1303)

Issue 2693403003: Remove the 10 second delay before user input generates engagement. (Closed)

Created:
1 year, 3 months ago by dominickn
Modified:
1 year, 2 months ago
Reviewers:
benwells
CC:
chromium-reviews, dominickn+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the 10 second delay before user input generates engagement. The site engagement service currently waits 10 seconds after navigation completes before allowing user input to generate engagement. This reduces the predictability of the service. Engagement also decays much more quickly now, meaning that the additional engagement earned when removing the 10 second wait is negligible. This CL instead allows engagement to be earned from the moment that the page finishes loading. BUG=692878 Review-Url: https://codereview.chromium.org/2693403003 Cr-Commit-Position: refs/heads/master@{#451942} Committed: https://chromium.googlesource.com/chromium/src/+/5ae55b8c8ed39e3a1019afba988b5df208f53420

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -10 lines) Patch
M chrome/browser/engagement/site_engagement_helper.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/engagement/site_engagement_helper.cc View 3 chunks +1 line, -9 lines 0 comments Download

Messages

Total messages: 19 (11 generated)
dominickn
PTAL, thanks! This could be done slightly more efficiently by removing the post tasking or ...
1 year, 3 months ago (2017-02-21 03:06:36 UTC) #6
benwells
On 2017/02/21 03:06:36, dominickn wrote: > PTAL, thanks! > > This could be done slightly ...
1 year, 3 months ago (2017-02-21 03:13:27 UTC) #7
benwells
lgtm
1 year, 3 months ago (2017-02-22 00:39:22 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2693403003/1
1 year, 3 months ago (2017-02-22 00:43:23 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_amd64-generic_chromium_compile_only_ng on ...
1 year, 2 months ago (2017-02-22 02:46:25 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2693403003/1
1 year, 2 months ago (2017-02-22 03:39:37 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/5ae55b8c8ed39e3a1019afba988b5df208f53420
1 year, 2 months ago (2017-02-22 09:00:41 UTC) #18
dominickn
1 year, 1 month ago (2017-04-03 02:41:17 UTC) #19
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2793863002/ by dominickn@chromium.org.

The reason for reverting is: This caused a perf regression (crbug.com/699749).

Powered by Google App Engine
This is Rietveld 408576698