Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 2793773002: Send IDC_HIDE_PAGE_INFO to close PageInfoView when reloading the page. (Closed)

Created:
3 years, 8 months ago by Olivier
Modified:
3 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

Send IDC_HIDE_PAGE_INFO to close PageInfoView when reloading the page. In M-58+, BVC must be informed if the Page Info controller is dismissed. This is caused by the check added in https://codereview.chromium.org/2672023002 that prevent displaying twice the page info. Use the command to dismiss the popup instead of dismissing it directly. BUG=697470 Review-Url: https://codereview.chromium.org/2723903005 Cr-Commit-Position: refs/heads/master@{#455067} (cherry picked from commit 61f85a6f747a80528881e5e3fa4d12d20325dc4b) Review-Url: https://codereview.chromium.org/2793773002 . Cr-Commit-Position: refs/branch-heads/3029@{#526} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/5f713b70e7d259383adabfce8112dbae4200b14f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -2 lines) Patch
M ios/chrome/browser/ui/omnibox/page_info_view_controller.mm View 4 chunks +9 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Olivier
3 years, 8 months ago (2017-04-01 05:31:55 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5f713b70e7d259383adabfce8112dbae4200b14f.

Powered by Google App Engine
This is Rietveld 408576698