[ios] Prevent multiple page security popups in voice over mode.

[ios] Prevent multiple page security popups in voice over mode.

BUG=671561
Review-Url: https://codereview.chromium.org/2672023002
Cr-Commit-Position: refs/heads/master@{#448373}
Committed: https://chromium.googlesource.com/chromium/src/+/b1a73cfd80b2a49985b7c5d186bfea6db0804c51

[justincohen, 2017-02-03 16:11:55]

Description was changed from

==========
Prevent multiple page security popups in voice over mode

BUG=671561
==========

to

==========
Prevent multiple page security popups in voice over mode.

BUG=671561
==========

[justincohen, 2017-02-03 16:13:31]

justincohen@chromium.org changed reviewers:
+ rohitrao@chromium.org

[justincohen, 2017-02-03 16:13:32]

ptal

[justincohen, 2017-02-03 17:59:26]

Description was changed from

==========
Prevent multiple page security popups in voice over mode.

BUG=671561
==========

to

==========
[ios] Prevent multiple page security popups in voice over mode.

BUG=671561
==========

[rohitrao (ping after 24h), 2017-02-06 14:02:14]

https://codereview.chromium.org/2672023002/diff/1/ios/chrome/browser/ui/brows...
File ios/chrome/browser/ui/browser_view_controller.mm (right):

https://codereview.chromium.org/2672023002/diff/1/ios/chrome/browser/ui/brows...
ios/chrome/browser/ui/browser_view_controller.mm:3421: // accessibility mode
Missing close paren.

Why is this only triggered by voiceover?  What is different when you tap quickly
without voiceover?

[justincohen, 2017-02-06 15:47:25]

If you tap quickly without voiceover your tap will hit the popup 'shield' and
dismiss the popup, then trigger the popup again.  So if you tap tap tap tap tap
you will see the popup alternate between dismissing and appearing dismissing and
appearing.

With accessibility you never tap the shield, since focus is still on the page
info icon momentarily.  There is code that changes the focus to the popup, but
one can tap quickly enough to beat this change.

[justincohen, 2017-02-06 15:49:54]

ptal

https://codereview.chromium.org/2672023002/diff/1/ios/chrome/browser/ui/brows...
File ios/chrome/browser/ui/browser_view_controller.mm (right):

https://codereview.chromium.org/2672023002/diff/1/ios/chrome/browser/ui/brows...
ios/chrome/browser/ui/browser_view_controller.mm:3421: // accessibility mode
On 2017/02/06 14:02:13, rohitrao wrote:
> Missing close paren.
> 
> Why is this only triggered by voiceover?  What is different when you tap
quickly
> without voiceover?

Done.

[rohitrao (ping after 24h), 2017-02-06 20:08:38]

lgtm

[justincohen, 2017-02-06 20:09:22]

The CQ bit was checked by justincohen@chromium.org

[commit-bot: I haz the power, 2017-02-06 20:10:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-06 20:25:48]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1486411762682260,
"parent_rev": "206251b17bbac92e0d8c4cae1d9a01f8da780f6b", "commit_rev":
"b1a73cfd80b2a49985b7c5d186bfea6db0804c51"}

[commit-bot: I haz the power, 2017-02-06 20:26:25]

Description was changed from

==========
[ios] Prevent multiple page security popups in voice over mode.

BUG=671561
==========

to

==========
[ios] Prevent multiple page security popups in voice over mode.

BUG=671561

Review-Url: https://codereview.chromium.org/2672023002
Cr-Commit-Position: refs/heads/master@{#448373}
Committed:
https://chromium.googlesource.com/chromium/src/+/b1a73cfd80b2a49985b7c5d186bf...
==========

[commit-bot: I haz the power, 2017-02-06 20:26:26]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/b1a73cfd80b2a49985b7c5d186bf...