Send IDC_HIDE_PAGE_INFO to close PageInfoView when reloading the page.

Send IDC_HIDE_PAGE_INFO to close PageInfoView when reloading the page.

In M-58+, BVC must be informed if the Page Info controller is dismissed.
This is caused by the check added in https://codereview.chromium.org/2672023002
that prevent displaying twice the page info.
Use the command to dismiss the popup instead of dismissing it directly.

BUG=697470
Review-Url: https://codereview.chromium.org/2723903005
Cr-Commit-Position: refs/heads/master@{#455067}
Committed: https://chromium.googlesource.com/chromium/src/+/61f85a6f747a80528881e5e3fa4d12d20325dc4b

[Olivier, 2017-03-02 10:08:44]

olivierrobin@chromium.org changed reviewers:
+ rohitrao@chromium.org

[rohitrao (ping after 24h), 2017-03-02 18:23:52]

What has changed in M58+ that requires BVC to handle this explicitly?  Could
that be added to a comment, the bug, or the CL description please?

[Olivier, 2017-03-03 09:43:46]

Description was changed from

==========
Send IDC_HIDE_PAGE_INFO to close PageInfoView when reloading the page.

In M-58+, BVC must be informed if the Page Info controller is dismissed.
Use the command to dismiss the popup instead of dismissing it directly.

BUG=697470
==========

to

==========
Send IDC_HIDE_PAGE_INFO to close PageInfoView when reloading the page.

In M-58+, BVC must be informed if the Page Info controller is dismissed.
This is caused by the check added in https://codereview.chromium.org/2672023002
that prevent displaying twice the page info.
Use the command to dismiss the popup instead of dismissing it directly.

BUG=697470
==========

[Olivier, 2017-03-03 09:44:17]

On 2017/03/02 18:23:52, rohitrao wrote:
> What has changed in M58+ that requires BVC to handle this explicitly?  Could
> that be added to a comment, the bug, or the CL description please?

I investigated.
This is caused by a check added in https://codereview.chromium.org/2672023002.
Added in CL description

[rohitrao (ping after 24h), 2017-03-07 14:03:34]

lgtm, thanks for the updated description.

[Olivier, 2017-03-07 14:06:52]

The CQ bit was checked by olivierrobin@chromium.org

[commit-bot: I haz the power, 2017-03-07 14:07:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-07 14:18:16]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1488895612473590, "parent_rev":
"16f6b71df5eb2305251e126767e6d99c08d24ba8", "commit_rev":
"61f85a6f747a80528881e5e3fa4d12d20325dc4b"}

[commit-bot: I haz the power, 2017-03-07 14:18:54]

Description was changed from

==========
Send IDC_HIDE_PAGE_INFO to close PageInfoView when reloading the page.

In M-58+, BVC must be informed if the Page Info controller is dismissed.
This is caused by the check added in https://codereview.chromium.org/2672023002
that prevent displaying twice the page info.
Use the command to dismiss the popup instead of dismissing it directly.

BUG=697470
==========

to

==========
Send IDC_HIDE_PAGE_INFO to close PageInfoView when reloading the page.

In M-58+, BVC must be informed if the Page Info controller is dismissed.
This is caused by the check added in https://codereview.chromium.org/2672023002
that prevent displaying twice the page info.
Use the command to dismiss the popup instead of dismissing it directly.

BUG=697470

Review-Url: https://codereview.chromium.org/2723903005
Cr-Commit-Position: refs/heads/master@{#455067}
Committed:
https://chromium.googlesource.com/chromium/src/+/61f85a6f747a80528881e5e3fa4d...
==========

[commit-bot: I haz the power, 2017-03-07 14:18:57]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/61f85a6f747a80528881e5e3fa4d...