Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Issue 2793443002: Revert of [inspector] convert V8Console static methods into members (Closed)

Created:
3 years, 8 months ago by kozy
Modified:
3 years, 8 months ago
Reviewers:
bbudge, dgozman
CC:
v8-reviews_googlegroups.com, devtools-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [inspector] convert V8Console static methods into members (patchset #2 id:20001 of https://codereview.chromium.org/2783073002/ ) Reason for revert: Too many simulatenously landed CLs, this one should be rebased first. Original issue's description: > [inspector] convert V8Console static methods into members > > This step is required to implement console as builtin which calls console delegate methods. > > BUG=v8:6168 > R=dgozman@chromium.org > > Review-Url: https://codereview.chromium.org/2783073002 > Cr-Commit-Position: refs/heads/master@{#44283} > Committed: https://chromium.googlesource.com/v8/v8/+/fe27dccd873024213b16d1e9810dda6a6c705571 TBR=dgozman@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:6168 Review-Url: https://codereview.chromium.org/2793443002 Cr-Commit-Position: refs/heads/master@{#44284} Committed: https://chromium.googlesource.com/v8/v8/+/5b306f7272c999f1235be66eb505bd264f680ae4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+200 lines, -220 lines) Patch
M src/inspector/injected-script.cc View 1 chunk +3 lines, -6 lines 0 comments Download
M src/inspector/inspected-context.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M src/inspector/v8-console.h View 2 chunks +56 lines, -57 lines 0 comments Download
M src/inspector/v8-console.cc View 18 chunks +139 lines, -144 lines 0 comments Download
M src/inspector/v8-inspector-impl.h View 3 chunks +0 lines, -4 lines 0 comments Download
M src/inspector/v8-inspector-impl.cc View 2 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
kozy
Created Revert of [inspector] convert V8Console static methods into members
3 years, 8 months ago (2017-03-30 22:33:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2793443002/1
3 years, 8 months ago (2017-03-30 22:33:47 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/v8/v8/+/5b306f7272c999f1235be66eb505bd264f680ae4
3 years, 8 months ago (2017-03-30 22:33:58 UTC) #6
bbudge
3 years, 8 months ago (2017-03-30 22:34:58 UTC) #8
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698