Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(395)

Side by Side Diff: src/inspector/v8-inspector-impl.cc

Issue 2793443002: Revert of [inspector] convert V8Console static methods into members (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/inspector/v8-inspector-impl.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2010-2011 Google Inc. All rights reserved. 2 * Copyright (c) 2010-2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 16 matching lines...) Expand all
27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
29 */ 29 */
30 30
31 #include "src/inspector/v8-inspector-impl.h" 31 #include "src/inspector/v8-inspector-impl.h"
32 32
33 #include "src/inspector/inspected-context.h" 33 #include "src/inspector/inspected-context.h"
34 #include "src/inspector/string-util.h" 34 #include "src/inspector/string-util.h"
35 #include "src/inspector/v8-console-agent-impl.h" 35 #include "src/inspector/v8-console-agent-impl.h"
36 #include "src/inspector/v8-console-message.h" 36 #include "src/inspector/v8-console-message.h"
37 #include "src/inspector/v8-console.h"
38 #include "src/inspector/v8-debugger-agent-impl.h" 37 #include "src/inspector/v8-debugger-agent-impl.h"
39 #include "src/inspector/v8-debugger.h" 38 #include "src/inspector/v8-debugger.h"
40 #include "src/inspector/v8-inspector-session-impl.h" 39 #include "src/inspector/v8-inspector-session-impl.h"
41 #include "src/inspector/v8-profiler-agent-impl.h" 40 #include "src/inspector/v8-profiler-agent-impl.h"
42 #include "src/inspector/v8-runtime-agent-impl.h" 41 #include "src/inspector/v8-runtime-agent-impl.h"
43 #include "src/inspector/v8-stack-trace-impl.h" 42 #include "src/inspector/v8-stack-trace-impl.h"
44 43
45 namespace v8_inspector { 44 namespace v8_inspector {
46 45
47 std::unique_ptr<V8Inspector> V8Inspector::create(v8::Isolate* isolate, 46 std::unique_ptr<V8Inspector> V8Inspector::create(v8::Isolate* isolate,
(...skipping 281 matching lines...) Expand 10 before | Expand all | Expand 10 after
329 return iter == m_contexts.end() ? nullptr : iter->second.get(); 328 return iter == m_contexts.end() ? nullptr : iter->second.get();
330 } 329 }
331 330
332 V8InspectorSessionImpl* V8InspectorImpl::sessionForContextGroup( 331 V8InspectorSessionImpl* V8InspectorImpl::sessionForContextGroup(
333 int contextGroupId) { 332 int contextGroupId) {
334 if (!contextGroupId) return nullptr; 333 if (!contextGroupId) return nullptr;
335 SessionMap::iterator iter = m_sessions.find(contextGroupId); 334 SessionMap::iterator iter = m_sessions.find(contextGroupId);
336 return iter == m_sessions.end() ? nullptr : iter->second; 335 return iter == m_sessions.end() ? nullptr : iter->second;
337 } 336 }
338 337
339 V8Console* V8InspectorImpl::console() {
340 if (!m_console) m_console.reset(new V8Console(this));
341 return m_console.get();
342 }
343
344 } // namespace v8_inspector 338 } // namespace v8_inspector
OLDNEW
« no previous file with comments | « src/inspector/v8-inspector-impl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698