[inspector] convert V8Console static methods into members

[inspector] convert V8Console static methods into members

This step is required to implement console as builtin which calls console delegate methods.

BUG=v8:6175
R=dgozman@chromium.org

Review-Url: https://codereview.chromium.org/2783073002
Cr-Original-Commit-Position: refs/heads/master@{#44283}
Committed: https://chromium.googlesource.com/v8/v8/+/fe27dccd873024213b16d1e9810dda6a6c705571
Review-Url: https://codereview.chromium.org/2783073002
Cr-Commit-Position: refs/heads/master@{#44285}
Committed: https://chromium.googlesource.com/v8/v8/+/545f99d02a5cb0b92f271405edb1466267ec582c

[kozy, 2017-03-30 01:24:36]

Description was changed from

==========
[inspector] convert V8Console static methods into members

This step is required to implement console as builtin which calls console
delegate methods.

BUG=chromium:588893
R=dgozman@chromium.org
==========

to

==========
[inspector] convert V8Console static methods into members

This step is required to implement console as builtin which calls console
delegate methods.

BUG=v8:6168
R=dgozman@chromium.org
==========

[kozy, 2017-03-30 01:25:24]

Dmitry, please take a look.

[dgozman, 2017-03-30 21:08:24]

lgtm

https://codereview.chromium.org/2783073002/diff/1/src/inspector/injected-scri...
File src/inspector/injected-script.cc (right):

https://codereview.chromium.org/2783073002/diff/1/src/inspector/injected-scri...
src/inspector/injected-script.cc:409: if (m_commandLineAPI.IsEmpty())
style: {} around next statement

https://codereview.chromium.org/2783073002/diff/1/src/inspector/v8-console.h
File src/inspector/v8-console.h (right):

https://codereview.chromium.org/2783073002/diff/1/src/inspector/v8-console.h#...
src/inspector/v8-console.h:49: explicit V8Console(V8InspectorImpl* inspector) :
m_inspector(inspector) {}
Move implementation to cc.

[kozy, 2017-03-30 21:52:41]

thanks! all done.

https://codereview.chromium.org/2783073002/diff/1/src/inspector/injected-scri...
File src/inspector/injected-script.cc (right):

https://codereview.chromium.org/2783073002/diff/1/src/inspector/injected-scri...
src/inspector/injected-script.cc:409: if (m_commandLineAPI.IsEmpty())
On 2017/03/30 21:08:24, dgozman wrote:
> style: {} around next statement

Done.

https://codereview.chromium.org/2783073002/diff/1/src/inspector/v8-console.h
File src/inspector/v8-console.h (right):

https://codereview.chromium.org/2783073002/diff/1/src/inspector/v8-console.h#...
src/inspector/v8-console.h:49: explicit V8Console(V8InspectorImpl* inspector) :
m_inspector(inspector) {}
On 2017/03/30 21:08:24, dgozman wrote:
> Move implementation to cc.

Done.

[kozy, 2017-03-30 21:52:48]

The CQ bit was checked by kozyatinskiy@chromium.org

[kozy, 2017-03-30 21:52:48]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2783073002/#ps20001
(title: "addressed comments")

[commit-bot: I haz the power, 2017-03-30 21:52:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-30 22:20:47]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490910768418790,
"parent_rev": "8adf294cb4700e069f3da27b941417560a68e5f3", "commit_rev":
"fe27dccd873024213b16d1e9810dda6a6c705571"}

[commit-bot: I haz the power, 2017-03-30 22:20:52]

Description was changed from

==========
[inspector] convert V8Console static methods into members

This step is required to implement console as builtin which calls console
delegate methods.

BUG=v8:6168
R=dgozman@chromium.org
==========

to

==========
[inspector] convert V8Console static methods into members

This step is required to implement console as builtin which calls console
delegate methods.

BUG=v8:6168
R=dgozman@chromium.org

Review-Url: https://codereview.chromium.org/2783073002
Cr-Commit-Position: refs/heads/master@{#44283}
Committed:
https://chromium.googlesource.com/v8/v8/+/fe27dccd873024213b16d1e9810dda6a6c7...
==========

[commit-bot: I haz the power, 2017-03-30 22:20:53]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/fe27dccd873024213b16d1e9810dda6a6c7...

[kozy, 2017-03-30 22:33:43]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2793443002/ by kozyatinskiy@chromium.org.

The reason for reverting is: Too many simulatenously landed CLs, this one should
be rebased first..

[kozy, 2017-03-30 22:43:42]

Description was changed from

==========
[inspector] convert V8Console static methods into members

This step is required to implement console as builtin which calls console
delegate methods.

BUG=v8:6168
R=dgozman@chromium.org

Review-Url: https://codereview.chromium.org/2783073002
Cr-Commit-Position: refs/heads/master@{#44283}
Committed:
https://chromium.googlesource.com/v8/v8/+/fe27dccd873024213b16d1e9810dda6a6c7...
==========

to

==========
[inspector] convert V8Console static methods into members

This step is required to implement console as builtin which calls console
delegate methods.

BUG=v8:6168
R=dgozman@chromium.org

Review-Url: https://codereview.chromium.org/2783073002
Cr-Commit-Position: refs/heads/master@{#44283}
Committed:
https://chromium.googlesource.com/v8/v8/+/fe27dccd873024213b16d1e9810dda6a6c7...
==========

[kozy, 2017-03-30 22:43:51]

The CQ bit was checked by kozyatinskiy@chromium.org

[kozy, 2017-03-30 22:43:51]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2783073002/#ps40001
(title: "rebased")

[commit-bot: I haz the power, 2017-03-30 22:43:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kozy, 2017-03-30 22:44:13]

Description was changed from

==========
[inspector] convert V8Console static methods into members

This step is required to implement console as builtin which calls console
delegate methods.

BUG=v8:6168
R=dgozman@chromium.org

Review-Url: https://codereview.chromium.org/2783073002
Cr-Commit-Position: refs/heads/master@{#44283}
Committed:
https://chromium.googlesource.com/v8/v8/+/fe27dccd873024213b16d1e9810dda6a6c7...
==========

to

==========
[inspector] convert V8Console static methods into members

This step is required to implement console as builtin which calls console
delegate methods.

BUG=v8:6175
R=dgozman@chromium.org

Review-Url: https://codereview.chromium.org/2783073002
Cr-Commit-Position: refs/heads/master@{#44283}
Committed:
https://chromium.googlesource.com/v8/v8/+/fe27dccd873024213b16d1e9810dda6a6c7...
==========

[commit-bot: I haz the power, 2017-03-30 23:07:25]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1490913831571370,
"parent_rev": "5b306f7272c999f1235be66eb505bd264f680ae4", "commit_rev":
"545f99d02a5cb0b92f271405edb1466267ec582c"}

[commit-bot: I haz the power, 2017-03-30 23:07:31]

Description was changed from

==========
[inspector] convert V8Console static methods into members

This step is required to implement console as builtin which calls console
delegate methods.

BUG=v8:6175
R=dgozman@chromium.org

Review-Url: https://codereview.chromium.org/2783073002
Cr-Commit-Position: refs/heads/master@{#44283}
Committed:
https://chromium.googlesource.com/v8/v8/+/fe27dccd873024213b16d1e9810dda6a6c7...
==========

to

==========
[inspector] convert V8Console static methods into members

This step is required to implement console as builtin which calls console
delegate methods.

BUG=v8:6175
R=dgozman@chromium.org

Review-Url: https://codereview.chromium.org/2783073002
Cr-Original-Commit-Position: refs/heads/master@{#44283}
Committed:
https://chromium.googlesource.com/v8/v8/+/fe27dccd873024213b16d1e9810dda6a6c7...
Review-Url: https://codereview.chromium.org/2783073002
Cr-Commit-Position: refs/heads/master@{#44285}
Committed:
https://chromium.googlesource.com/v8/v8/+/545f99d02a5cb0b92f271405edb1466267e...
==========

[commit-bot: I haz the power, 2017-03-30 23:07:32]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/545f99d02a5cb0b92f271405edb1466267e...