Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Issue 2793433002: Delete several unused GYP scripts from build/mac and chrome/tools/build/mac. (Closed)

Created:
3 years, 8 months ago by Robert Sesek
Modified:
3 years, 8 months ago
Reviewers:
Mark Mentovai, Nico
CC:
chromium-reviews, grt+watch_chromium.org, pennymac+watch_chromium.org, wfh+watch_chromium.org, mac-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Delete several unused GYP scripts from build/mac and chrome/tools/build/mac. This also adds rsesek@ as an OWNER of chrome/tools/build/mac. BUG=615107 R=mark@chromium.org TBR=thakis@chromium.org Review-Url: https://codereview.chromium.org/2793433002 Cr-Commit-Position: refs/heads/master@{#460981} Committed: https://chromium.googlesource.com/chromium/src/+/4a22fdb230ae32c544d870cb55fbf3643a82adb9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -859 lines) Patch
D build/mac/copy_asan_runtime_dylib.sh View 1 chunk +0 lines, -76 lines 0 comments Download
D build/mac/copy_framework_unversioned.sh View 1 chunk +0 lines, -118 lines 0 comments Download
D build/mac/strip_from_xcode View 1 chunk +0 lines, -62 lines 0 comments Download
D build/mac/strip_save_dsym View 1 chunk +0 lines, -335 lines 0 comments Download
M chrome/installer/mac/sign_versioned_dir.sh.in View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/tools/build/mac/OWNERS View 1 chunk +1 line, -1 line 0 comments Download
D chrome/tools/build/mac/clean_up_old_versions View 1 chunk +0 lines, -26 lines 0 comments Download
D chrome/tools/build/mac/dump_product_syms View 1 chunk +0 lines, -179 lines 0 comments Download
D chrome/tools/build/mac/make_locale_dirs.sh View 1 chunk +0 lines, -39 lines 0 comments Download
D chrome/tools/mac_helpers/lipo_thin_x86_64.sh View 1 chunk +0 lines, -18 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
Robert Sesek
3 years, 8 months ago (2017-03-30 22:47:19 UTC) #4
Mark Mentovai
LGTM
3 years, 8 months ago (2017-03-30 23:35:37 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2793433002/1
3 years, 8 months ago (2017-03-31 00:59:22 UTC) #9
Robert Sesek
TBRing thakis to rm chrome/tools/mac_helpers/lipo_thin_x86_64.sh
3 years, 8 months ago (2017-03-31 01:13:00 UTC) #12
Nico
3 years, 8 months ago (2017-03-31 01:21:39 UTC) #13
Nico
lgtm
3 years, 8 months ago (2017-03-31 01:21:43 UTC) #14
commit-bot: I haz the power
3 years, 8 months ago (2017-03-31 01:36:47 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4a22fdb230ae32c544d870cb55fb...

Powered by Google App Engine
This is Rietveld 408576698