Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2228)

Unified Diff: chrome/installer/mac/sign_versioned_dir.sh.in

Issue 2793433002: Delete several unused GYP scripts from build/mac and chrome/tools/build/mac. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/mac/strip_save_dsym ('k') | chrome/tools/build/mac/OWNERS » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/installer/mac/sign_versioned_dir.sh.in
diff --git a/chrome/installer/mac/sign_versioned_dir.sh.in b/chrome/installer/mac/sign_versioned_dir.sh.in
index f511916a39f2be51cd7edb1eb6ae69006c0900d1..2d03ee453af61ca71ca599ff4c36a9d83278d23f 100644
--- a/chrome/installer/mac/sign_versioned_dir.sh.in
+++ b/chrome/installer/mac/sign_versioned_dir.sh.in
@@ -44,11 +44,11 @@ codesign_id="${3}"
versioned_dir="${app_path}/Contents/Versions/@VERSION@"
-# An .app bundle to be signed can be signed directly. Normally, signing a
-# framework bundle requires that each version within be signed individually.
-# http://developer.apple.com/mac/library/technotes/tn2007/tn2206.html#TNTAG13
-# In Chrome's case, the framework bundle is unversioned, so it too can be
-# signed directly. See copy_framework_unversioned.sh.
+# To sign an .app bundle that contains nested code, the nested components
+# themselves must be signed. Each of these components is signed below. Note
+# that unless a framework has multiple versions (which is discouraged), signing
+# the entire framework is equivalent to signing the Current version.
+# https://developer.apple.com/library/content/technotes/tn2206/_index.html#//apple_ref/doc/uid/DTS40007919-CH1-TNTAG13
framework="${versioned_dir}/@MAC_PRODUCT_NAME@ Framework.framework"
notification_service="${framework}/XPCServices/AlertNotificationService.xpc"
« no previous file with comments | « build/mac/strip_save_dsym ('k') | chrome/tools/build/mac/OWNERS » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698