Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Unified Diff: third_party/WebKit/Source/core/dom/StaticRange.h

Issue 2793093002: [InputEvent] Update spec link for StaticRange.idl and use unsigned offset (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/StaticRange.h
diff --git a/third_party/WebKit/Source/core/dom/StaticRange.h b/third_party/WebKit/Source/core/dom/StaticRange.h
index fa007e37a04387fdcd4be052af2e3f9b3b15174a..3d1eb9bcc71b4a4ab1f47f52fb66cfb42dda4a56 100644
--- a/third_party/WebKit/Source/core/dom/StaticRange.h
+++ b/third_party/WebKit/Source/core/dom/StaticRange.h
@@ -2,8 +2,6 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-// https://discourse.wicg.io/t/proposal-staticrange-to-be-used-instead-of-range-for-new-apis/1472
-
#ifndef StaticRange_h
#define StaticRange_h
@@ -28,9 +26,9 @@ class CORE_EXPORT StaticRange final : public GarbageCollected<StaticRange>,
}
static StaticRange* create(Document& document,
Node* startContainer,
- int startOffset,
+ unsigned startOffset,
Node* endContainer,
- int endOffset) {
+ unsigned endOffset) {
return new StaticRange(document, startContainer, startOffset, endContainer,
endOffset);
}
@@ -53,21 +51,21 @@ class CORE_EXPORT StaticRange final : public GarbageCollected<StaticRange>,
m_startContainer = startContainer;
}
- int startOffset() const { return m_startOffset; }
- void setStartOffset(int startOffset) { m_startOffset = startOffset; }
+ unsigned startOffset() const { return m_startOffset; }
+ void setStartOffset(unsigned startOffset) { m_startOffset = startOffset; }
Node* endContainer() const { return m_endContainer.get(); }
void setEndContainer(Node* endContainer) { m_endContainer = endContainer; }
- int endOffset() const { return m_endOffset; }
- void setEndOffset(int endOffset) { m_endOffset = endOffset; }
+ unsigned endOffset() const { return m_endOffset; }
+ void setEndOffset(unsigned endOffset) { m_endOffset = endOffset; }
bool collapsed() const {
return m_startContainer == m_endContainer && m_startOffset == m_endOffset;
}
- void setStart(Node* container, int offset);
- void setEnd(Node* container, int offset);
+ void setStart(Node* container, unsigned offset);
+ void setEnd(Node* container, unsigned offset);
Range* toRange(ExceptionState& = ASSERT_NO_EXCEPTION) const;
@@ -77,15 +75,15 @@ class CORE_EXPORT StaticRange final : public GarbageCollected<StaticRange>,
explicit StaticRange(Document&);
StaticRange(Document&,
Node* startContainer,
- int startOffset,
+ unsigned startOffset,
Node* endContainer,
- int endOffset);
+ unsigned endOffset);
Member<Document> m_ownerDocument; // Required by |toRange()|.
Member<Node> m_startContainer;
- int m_startOffset;
+ unsigned m_startOffset;
Member<Node> m_endContainer;
- int m_endOffset;
+ unsigned m_endOffset;
};
using StaticRangeVector = HeapVector<Member<StaticRange>>;
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/dom/StaticRange.cpp » ('j') | third_party/WebKit/Source/core/dom/StaticRange.idl » ('J')

Powered by Google App Engine
This is Rietveld 408576698