Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(457)

Issue 2792883002: Revert of [headless] Use individual aura::WindowTreeHosts per WebContents. (Closed)

Created:
3 years, 8 months ago by Timothy Loh
Modified:
3 years, 8 months ago
Reviewers:
Sami, Eric Seckler
CC:
chromium-reviews, mac-reviews_chromium.org, irisu, dvallet
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [headless] Use individual aura::WindowTreeHosts per WebContents. (patchset #1 id:1 of https://codereview.chromium.org/2787373002/ ) Reason for revert: Suspect this is causing failures of TargetDomainCreateTwoContexts.RunAsyncTest in browser_side_navigation_headless_browsertests. https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29?numbuilds=200 Original issue's description: > [headless] Use individual aura::WindowTreeHosts per WebContents. > > This way, compositing concerns are handled separately per WebContents, > which is required for BeginFrameControl. > > BUG=646774 > > Review-Url: https://codereview.chromium.org/2787373002 > Cr-Commit-Position: refs/heads/master@{#461200} > Committed: https://chromium.googlesource.com/chromium/src/+/56b635d784ad0eacbd06e744e43c115e48993a04 TBR=skyostil@chromium.org,eseckler@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=646774 Review-Url: https://codereview.chromium.org/2792883002 Cr-Commit-Position: refs/heads/master@{#461367} Committed: https://chromium.googlesource.com/chromium/src/+/9f50c75ebf30e61ad79311c1271655c7573261c5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -51 lines) Patch
M headless/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
M headless/lib/browser/headless_browser_impl.h View 2 chunks +19 lines, -1 line 0 comments Download
M headless/lib/browser/headless_browser_impl_aura.cc View 3 chunks +17 lines, -16 lines 0 comments Download
M headless/lib/browser/headless_browser_impl_mac.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M headless/lib/browser/headless_web_contents_impl.h View 3 chunks +0 lines, -9 lines 0 comments Download
M headless/lib/browser/headless_web_contents_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M headless/lib/browser/headless_window_tree_host.h View 3 chunks +1 line, -14 lines 0 comments Download
M headless/lib/browser/headless_window_tree_host.cc View 2 chunks +1 line, -6 lines 0 comments Download
M headless/lib/headless_web_contents_browsertest.cc View 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
Timothy Loh
Created Revert of [headless] Use individual aura::WindowTreeHosts per WebContents.
3 years, 8 months ago (2017-04-03 01:50:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2792883002/1
3 years, 8 months ago (2017-04-03 01:50:52 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/9f50c75ebf30e61ad79311c1271655c7573261c5
3 years, 8 months ago (2017-04-03 03:57:53 UTC) #6
Eric Seckler
3 years, 8 months ago (2017-04-03 09:35:20 UTC) #7
Message was sent while issue was closed.
lgtm. seems like this was caused by timing changes that surfaced a race in the
test. fix for the test is out on https://codereview.chromium.org/2794883002/.

Powered by Google App Engine
This is Rietveld 408576698