Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(731)

Unified Diff: headless/lib/headless_web_contents_browsertest.cc

Issue 2792883002: Revert of [headless] Use individual aura::WindowTreeHosts per WebContents. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « headless/lib/browser/headless_window_tree_host.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: headless/lib/headless_web_contents_browsertest.cc
diff --git a/headless/lib/headless_web_contents_browsertest.cc b/headless/lib/headless_web_contents_browsertest.cc
index 50a493769fec9eb6851cfc02349d6b0715c8f2eb..67fee60f2086f5f0d404b30be5e08fb45c5130e1 100644
--- a/headless/lib/headless_web_contents_browsertest.cc
+++ b/headless/lib/headless_web_contents_browsertest.cc
@@ -86,12 +86,19 @@
.Build();
EXPECT_TRUE(WaitForLoad(web_contents2));
- // Focus of different WebContents is independent.
+ // TODO(irisu): Focus of two web contents should be independent of the other.
+ // Both web_contents and web_contents2 should be focused at this point.
+ // NOTE(dvallet): Mac headless implementation already does this.
EXPECT_TRUE(EvaluateScript(web_contents, "document.hasFocus()")
->GetResult()
->GetValue()
->GetAsBoolean(&result));
+#if !defined(OS_MACOSX)
+ EXPECT_FALSE(result);
+#else
+ // Mac sets all contents as focused.
EXPECT_TRUE(result);
+#endif
EXPECT_TRUE(EvaluateScript(web_contents2, "document.hasFocus()")
->GetResult()
->GetValue()
« no previous file with comments | « headless/lib/browser/headless_window_tree_host.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698