Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issue 2787373002: [headless] Use individual aura::WindowTreeHosts per WebContents. (Closed)

Created:
3 years, 8 months ago by Eric Seckler
Modified:
3 years, 8 months ago
Reviewers:
Sami
CC:
chromium-reviews, mac-reviews_chromium.org, irisu, dvallet
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[headless] Use individual aura::WindowTreeHosts per WebContents. This way, compositing concerns are handled separately per WebContents, which is required for BeginFrameControl. BUG=646774 Review-Url: https://codereview.chromium.org/2787373002 Cr-Original-Commit-Position: refs/heads/master@{#461200} Committed: https://chromium.googlesource.com/chromium/src/+/56b635d784ad0eacbd06e744e43c115e48993a04 Review-Url: https://codereview.chromium.org/2787373002 Cr-Commit-Position: refs/heads/master@{#461414} Committed: https://chromium.googlesource.com/chromium/src/+/c09e3997a3688d11623054205f4b25e4f8e7dba7

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -50 lines) Patch
M headless/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
M headless/lib/browser/headless_browser_impl.h View 2 chunks +1 line, -19 lines 0 comments Download
M headless/lib/browser/headless_browser_impl_aura.cc View 3 chunks +16 lines, -17 lines 1 comment Download
M headless/lib/browser/headless_browser_impl_mac.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M headless/lib/browser/headless_web_contents_impl.h View 3 chunks +9 lines, -0 lines 0 comments Download
M headless/lib/browser/headless_web_contents_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M headless/lib/browser/headless_window_tree_host.h View 3 chunks +14 lines, -1 line 0 comments Download
M headless/lib/browser/headless_window_tree_host.cc View 2 chunks +6 lines, -1 line 0 comments Download
M headless/lib/headless_web_contents_browsertest.cc View 1 chunk +1 line, -8 lines 0 comments Download

Messages

Total messages: 28 (20 generated)
Eric Seckler
3 years, 8 months ago (2017-03-31 16:30:46 UTC) #2
Sami
Great, lgtm! https://codereview.chromium.org/2787373002/diff/1/headless/lib/browser/headless_browser_impl_aura.cc File headless/lib/browser/headless_browser_impl_aura.cc (right): https://codereview.chromium.org/2787373002/diff/1/headless/lib/browser/headless_browser_impl_aura.cc#newcode25 headless/lib/browser/headless_browser_impl_aura.cc:25: // (or at least BrowserContexts). N.B. this ...
3 years, 8 months ago (2017-03-31 17:53:51 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2787373002/1
3 years, 8 months ago (2017-03-31 20:03:57 UTC) #17
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/56b635d784ad0eacbd06e744e43c115e48993a04
3 years, 8 months ago (2017-03-31 20:11:35 UTC) #20
Timothy Loh
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2792883002/ by timloh@chromium.org. ...
3 years, 8 months ago (2017-04-03 01:50:45 UTC) #21
Eric Seckler
Fix for patch submitted in https://codereview.chromium.org/2794883002/. Let's retry this!
3 years, 8 months ago (2017-04-03 10:49:07 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2787373002/1
3 years, 8 months ago (2017-04-03 10:49:25 UTC) #25
commit-bot: I haz the power
3 years, 8 months ago (2017-04-03 13:11:32 UTC) #28
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c09e3997a3688d11623054205f4b...

Powered by Google App Engine
This is Rietveld 408576698