Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(501)

Issue 2792863002: Revert of Skip paint property update and visual rect update if no geometry change (Closed)

Created:
3 years, 8 months ago by Timothy Loh
Modified:
3 years, 8 months ago
Reviewers:
pdr., Xianzhu, chrishtr
CC:
ajuma+watch-canvas_chromium.org, blink-reviews, blink-reviews-frames_chromium.org, blink-reviews-html_chromium.org, blink-reviews-layout_chromium.org, blink-reviews-paint_chromium.org, Rik, chromium-reviews, dglazkov+blink, dshwang, krit, eae+blinkwatch, fmalita+watch_chromium.org, fs, gyuyoung2, jchaffraix+rendering, Justin Novosad, kinuko+watch, kouhei+svg_chromium.org, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Skip paint property update and visual rect update if no geometry change (patchset #25 id:480001 of https://codereview.chromium.org/2732573003/ ) Reason for revert: Looks like this is making tests fail on most builders, e.g. https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty/builds/25101 Original issue's description: > Skip paint property update and visual rect update if no geometry change > > This avoids unnecessary visual rect computation and update of paint > offset related paint properties. > > BUG=697081, 685179 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > > Review-Url: https://codereview.chromium.org/2732573003 > Cr-Commit-Position: refs/heads/master@{#461348} > Committed: https://chromium.googlesource.com/chromium/src/+/81f28ed19f771fe93406496d1d23da137abcd602 TBR=pdr@chromium.org,chrishtr@chromium.org,wangxianzhu@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=697081, 685179 Review-Url: https://codereview.chromium.org/2792863002 Cr-Commit-Position: refs/heads/master@{#461357} Committed: https://chromium.googlesource.com/chromium/src/+/6d954094c746673d37970ab1321e810622c8fd49

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+152 lines, -451 lines) Patch
M third_party/WebKit/Source/core/editing/CaretDisplayItemClient.cpp View 2 chunks +8 lines, -17 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameView.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.h View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/PaintInvalidationState.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/PaintInvalidationState.cpp View 2 chunks +7 lines, -2 lines 0 comments Download
D third_party/WebKit/Source/core/paint/FindPaintOffsetAndVisualRectNeedingUpdate.h View 1 chunk +0 lines, -181 lines 0 comments Download
M third_party/WebKit/Source/core/paint/FindPropertiesNeedingUpdate.h View 4 chunks +9 lines, -21 lines 0 comments Download
M third_party/WebKit/Source/core/paint/ObjectPaintInvalidator.cpp View 4 chunks +6 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintInvalidationCapableScrollableArea.cpp View 4 chunks +5 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintInvalidator.h View 4 chunks +10 lines, -26 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintInvalidator.cpp View 11 chunks +66 lines, -70 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.h View 2 chunks +2 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp View 2 chunks +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PrePaintTreeWalk.h View 1 chunk +2 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PrePaintTreeWalk.cpp View 5 chunks +35 lines, -70 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Timothy Loh
Created Revert of Skip paint property update and visual rect update if no geometry change
3 years, 8 months ago (2017-04-03 01:42:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2792863002/1
3 years, 8 months ago (2017-04-03 01:42:32 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/6d954094c746673d37970ab1321e810622c8fd49
3 years, 8 months ago (2017-04-03 01:44:39 UTC) #6
Xianzhu
3 years, 8 months ago (2017-04-03 16:59:51 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2792063002/ by wangxianzhu@chromium.org.

The reason for reverting is: (Not for landing yet. Just create a reland CL.).

Powered by Google App Engine
This is Rietveld 408576698