Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(467)

Unified Diff: third_party/WebKit/Source/core/layout/PaintInvalidationState.cpp

Issue 2792863002: Revert of Skip paint property update and visual rect update if no geometry change (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/PaintInvalidationState.cpp
diff --git a/third_party/WebKit/Source/core/layout/PaintInvalidationState.cpp b/third_party/WebKit/Source/core/layout/PaintInvalidationState.cpp
index 957df9c216b0eb77168dc155f029fa51fff97df7..5fd170864b56105a61e443e271fefd22b4afbc01 100644
--- a/third_party/WebKit/Source/core/layout/PaintInvalidationState.cpp
+++ b/third_party/WebKit/Source/core/layout/PaintInvalidationState.cpp
@@ -630,6 +630,11 @@
#endif // CHECK_FAST_PATH_SLOW_PATH_EQUALITY
+static const PaintPropertyTreeBuilderContext& dummyTreeBuilderContext() {
+ DEFINE_STATIC_LOCAL(PaintPropertyTreeBuilderContext, dummyContext, ());
+ return dummyContext;
+}
+
static GeometryMapper& dummyGeometryMapper() {
DEFINE_STATIC_LOCAL(std::unique_ptr<GeometryMapper>, dummyMapper,
(GeometryMapper::create()));
@@ -638,9 +643,9 @@
PaintInvalidatorContextAdapter::PaintInvalidatorContextAdapter(
const PaintInvalidationState& paintInvalidationState)
- // The dummy parameter will be never used because the overriding
+ // The dummy parameters will be never used because the overriding
// mapLocalRectToVisualRectInBacking() uses PaintInvalidationState.
- : PaintInvalidatorContext(nullptr, dummyGeometryMapper()),
+ : PaintInvalidatorContext(dummyTreeBuilderContext(), dummyGeometryMapper()),
m_paintInvalidationState(paintInvalidationState) {
forcedSubtreeInvalidationFlags =
paintInvalidationState.m_forcedSubtreeInvalidationFlags;

Powered by Google App Engine
This is Rietveld 408576698