Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issue 2792383003: Rename ScopedComPtr::Release() to ScopedComPtr::Reset() (Closed)

Created:
3 years, 8 months ago by robliao
Modified:
3 years, 8 months ago
CC:
chromium-reviews, vmpstr+watch_chromium.org, posciak+watch_chromium.org, chfremer+watch_chromium.org, pennymac+watch_chromium.org, dougt+watch_chromium.org, dmazzoni+watch_chromium.org, miu+watch_chromium.org, aboxhall+watch_chromium.org, grt+watch_chromium.org, chromoting-reviews_chromium.org, jam, je_julie, darin-cc_chromium.org, wanming.lin, xjz+watch_chromium.org, yuzo+watch_chromium.org, feature-media-reviews_chromium.org, timvolodine, mlamouri+watch-sensors_chromium.org, piman+watch_chromium.org, shalamov, riju_, Lei Zhang, wfh+watch_chromium.org, nektar+watch_chromium.org, tommycli, dtseng+watch_chromium.org, tfarina, danakj+watch_chromium.org, Mikhail
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename ScopedComPtr::Release() to ScopedComPtr::Reset() This renames Release() to Reset() to harmonize with ComPtr::Reset(). BUG=638327 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win10_chromium_x64_rel_ng;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=jam@chromium.org, reillyg@chromium.org, kbr@chromium.org, chcunningham@chromium.org Review-Url: https://codereview.chromium.org/2792383003 Cr-Commit-Position: refs/heads/master@{#462534} Committed: https://chromium.googlesource.com/chromium/src/+/9212cb4b406d2ea04de856efeec473fc6276211f

Patch Set 1 #

Patch Set 2 : Fix New Callers #

Unified diffs Side-by-side diffs Delta from patch set Stats (+137 lines, -136 lines) Patch
M base/win/scoped_comptr.h View 2 chunks +5 lines, -3 lines 0 comments Download
M base/win/scoped_comptr_unittest.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M base/win/shortcut.cc View 2 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/google/google_update_win.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/importer/ie_importer_browsertest_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media_galleries/win/snapshot_file_details.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/shell_integration_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/status_icons/status_tray_state_changer_win.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/win/settings_app_monitor.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/gcapi/gcapi.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/service/cloud_print/print_system_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/utility/importer/ie_importer_win.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/accessibility/accessibility_win_browsertest.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_win_unittest.cc View 11 chunks +28 lines, -28 lines 0 comments Download
M device/generic_sensor/platform_sensor_and_provider_unittest_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M device/generic_sensor/platform_sensor_provider_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M device/sensors/data_fetcher_shared_memory_win.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M gpu/ipc/service/direct_composition_surface_win.cc View 8 chunks +10 lines, -10 lines 0 comments Download
M media/audio/win/core_audio_util_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M media/capture/video/win/pin_base_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/capture/video/win/video_capture_device_factory_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M media/capture/video/win/video_capture_device_mf_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/capture/video/win/video_capture_device_win.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M media/gpu/dxva_picture_buffer_win.cc View 5 chunks +11 lines, -11 lines 0 comments Download
M media/gpu/dxva_video_decode_accelerator_win.cc View 1 4 chunks +17 lines, -17 lines 0 comments Download
M media/gpu/media_foundation_video_encode_accelerator_win.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M remoting/host/audio_capturer_win.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M remoting/host/setup/win/auth_code_getter.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/win/rdp_client_window.cc View 2 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 40 (29 generated)
robliao
scottmg: Please review this CL. Thanks!
3 years, 8 months ago (2017-04-04 17:18:06 UTC) #5
scottmg
lgtm
3 years, 8 months ago (2017-04-04 17:36:11 UTC) #7
joedow
remoting/ lgtm
3 years, 8 months ago (2017-04-04 18:35:45 UTC) #9
robliao
TBR'ing all reviewers except for joedow (Thanks!) for this mechanical rename of ScopedComPtr::Release() to ScopedComPtr::Reset() ...
3 years, 8 months ago (2017-04-04 19:37:10 UTC) #15
Reilly Grant (use Gerrit)
device/* lgtm
3 years, 8 months ago (2017-04-04 19:39:12 UTC) #16
commit-bot: I haz the power
This CL has an open dependency (Issue 2792173003 Patch 1). Please resolve the dependency and ...
3 years, 8 months ago (2017-04-04 19:50:08 UTC) #19
jam
lgtm
3 years, 8 months ago (2017-04-04 19:57:54 UTC) #20
Ken Russell (switch to Gerrit)
gpu/ lgtm
3 years, 8 months ago (2017-04-04 20:00:00 UTC) #21
chcunningham
media LGTM
3 years, 8 months ago (2017-04-04 20:13:40 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2792383003/20001
3 years, 8 months ago (2017-04-06 17:05:34 UTC) #37
commit-bot: I haz the power
3 years, 8 months ago (2017-04-06 17:44:33 UTC) #40
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/9212cb4b406d2ea04de856efeec4...

Powered by Google App Engine
This is Rietveld 408576698