chrome/browser/shell_integration_win.cc - Issue 2792383003: Rename ScopedComPtr::Release() to ScopedComPtr::Reset()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/shell_integration_win.cc

Issue 2792383003: Rename ScopedComPtr::Release() to ScopedComPtr::Reset() (Closed)

Patch Set: Fix New Callers Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/shell_integration_win.cc

diff --git a/chrome/browser/shell_integration_win.cc b/chrome/browser/shell_integration_win.cc

index 0611ded4d646e53e4c0060ceea63fb040871f77b..46853b8f4ae9a2e869751a22cd5734582e33aeda 100644

--- a/chrome/browser/shell_integration_win.cc

+++ b/chrome/browser/shell_integration_win.cc

@@ -839,8 +839,8 @@ int MigrateShortcutsInPathInternal(const base::FilePath& chrome_exe,

}

- persist_file.Release();

- shell_link.Release();

+ persist_file.Reset();

+ shell_link.Reset();

// Update the shortcut if some of its properties need to be updated.

if (updated_properties.options &&