chrome/installer/gcapi/gcapi.cc - Issue 2792383003: Rename ScopedComPtr::Release() to ScopedComPtr::Reset()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/gcapi/gcapi.cc

Issue 2792383003: Rename ScopedComPtr::Release() to ScopedComPtr::Reset() (Closed)

Patch Set: Fix New Callers Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/installer/gcapi/gcapi.cc

diff --git a/chrome/installer/gcapi/gcapi.cc b/chrome/installer/gcapi/gcapi.cc

index 45e64ea7c432045e628988f9ead3b2501fa43131..9f5de5ca8589a87aaed3cf121753796a1c27f48b 100644

--- a/chrome/installer/gcapi/gcapi.cc

+++ b/chrome/installer/gcapi/gcapi.cc

@@ -493,7 +493,7 @@ BOOL __stdcall LaunchGoogleChrome() {

if (SUCCEEDED(ipl->LaunchCmdLine(

chrome_command.GetCommandLineString().c_str())))

ret = true;

- ipl.Release();

+ ipl.Reset();

} else {

// Couldn't get Omaha's process launcher, Omaha may not be installed at

// system level. Try just running Chrome instead.