Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(23)

Issue 2792343003: Revert of Instrumented libraries: Remove dependence on GYP_DEFINES (Closed)

Created:
2 years, 8 months ago by Tom Anderson
Modified:
2 years, 8 months ago
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Instrumented libraries: Remove dependence on GYP_DEFINES (patchset #2 id:60001 of https://codereview.chromium.org/2775913002/ ) Reason for revert: Reverting now that all of the third_party changes have been reverted Original issue's description: > Instrumented libraries: Remove dependence on GYP_DEFINES > > This CL ports download_binaries.py and unpack_binaries.py from using > GYP_DEFINES to gn args. Previously, there was a gotcha step where you > had to run 'gclient sync' with the right GYP_DEFINES to actually download > the prebuilt instrumented libraries. This CL removes that step. > > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_msan_rel_ng;master.tryserver.chromium.linux:linux_chromium_chromeos_msan_rel_ng > R=eugenis@chromium.org > BUG=705072 > > Review-Url: https://codereview.chromium.org/2775913002 > Cr-Commit-Position: refs/heads/master@{#459630} > Committed: https://chromium.googlesource.com/chromium/src/+/5adb8c047852670be6c9d42114f3a17d44b6c56e TBR=eugenis@chromium.org,dpranke@chromium.org,machenbach@chromium.org,thomasanderson@google.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=705072 Review-Url: https://codereview.chromium.org/2792343003 Cr-Commit-Position: refs/heads/master@{#461871} Committed: https://chromium.googlesource.com/chromium/src/+/aa441f50eecca13f2d3490a89705cb00cc0d5920

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -30 lines) Patch
M DEPS View 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/instrumented_libraries/BUILD.gn View 1 chunk +5 lines, -14 lines 0 comments Download
M third_party/instrumented_libraries/scripts/download_binaries.py View 1 chunk +46 lines, -11 lines 0 comments Download
M third_party/instrumented_libraries/scripts/unpack_binaries.py View 1 chunk +16 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Tom Anderson
Created Revert of Instrumented libraries: Remove dependence on GYP_DEFINES
2 years, 8 months ago (2017-04-04 21:00:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2792343003/1
2 years, 8 months ago (2017-04-04 21:01:15 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/aa441f50eecca13f2d3490a89705cb00cc0d5920
2 years, 8 months ago (2017-04-04 22:36:32 UTC) #6
Dirk Pranke
2 years, 8 months ago (2017-04-04 23:17:43 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698