Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Unified Diff: third_party/instrumented_libraries/BUILD.gn

Issue 2792343003: Revert of Instrumented libraries: Remove dependence on GYP_DEFINES (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « DEPS ('k') | third_party/instrumented_libraries/scripts/download_binaries.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/instrumented_libraries/BUILD.gn
diff --git a/third_party/instrumented_libraries/BUILD.gn b/third_party/instrumented_libraries/BUILD.gn
index 4d1e910ba4d34902cdd20c7280caefc7ddcecf95..9d7636a8eec3b6c5167776eec5050e32407db877 100644
--- a/third_party/instrumented_libraries/BUILD.gn
+++ b/third_party/instrumented_libraries/BUILD.gn
@@ -57,27 +57,18 @@
}
}
- action("download_prebuilt_instrumented_libraries") {
- tarfile_name = "$archive_prefix-$instrumented_libraries_platform.tgz"
- shafile = "binaries/$tarfile_name.sha1"
- tarfile = "$target_out_dir/$tarfile_name"
- inputs = [ shafile ]
- outputs = [ tarfile ]
- script = "scripts/download_binaries.py"
- args = [ rebase_path(shafile), rebase_path(tarfile) ]
- }
-
+ # TODO(GYP): scripts/download_binaries.py uses GYP_DEFINES to decide whether
+ # to download the archives extracted here.
# Note: This requires a clobber whenever Ubuntu version changes.
action("extract_prebuilt_instrumented_libraries") {
- deps = [ ":download_prebuilt_instrumented_libraries" ]
visibility = [ ":prebuilt" ]
script = "scripts/unpack_binaries.py"
depfile = "$target_out_dir/$archive_prefix.d"
- tarfile = get_target_outputs(":download_prebuilt_instrumented_libraries")
args = [
- rebase_path(tarfile[0]),
- rebase_path("$target_out_dir/$archive_prefix.txt"),
+ archive_prefix,
+ rebase_path("binaries"),
rebase_path(root_out_dir + "/instrumented_libraries_prebuilt"),
+ rebase_path(target_out_dir, root_out_dir),
]
outputs = [
"$target_out_dir/$archive_prefix.txt",
« no previous file with comments | « DEPS ('k') | third_party/instrumented_libraries/scripts/download_binaries.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698