Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2775913002:
Instrumented libraries: Remove dependence on GYP_DEFINES (Closed)
|
Created:
3 years, 9 months ago by Tom (Use chromium acct) Modified:
3 years, 8 months ago CC:
chromium-reviews Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionInstrumented libraries: Remove dependence on GYP_DEFINES
This CL ports download_binaries.py and unpack_binaries.py from using
GYP_DEFINES to gn args. Previously, there was a gotcha step where you
had to run 'gclient sync' with the right GYP_DEFINES to actually download
the prebuilt instrumented libraries. This CL removes that step.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_msan_rel_ng;master.tryserver.chromium.linux:linux_chromium_chromeos_msan_rel_ng
R=eugenis@chromium.org
BUG=705072
Review-Url: https://codereview.chromium.org/2775913002
Cr-Commit-Position: refs/heads/master@{#459630}
Committed: https://chromium.googlesource.com/chromium/src/+/5adb8c047852670be6c9d42114f3a17d44b6c56e
Patch Set 1 #Patch Set 2 : fix python syntax #
Total comments: 2
Messages
Total messages: 29 (22 generated)
The CQ bit was checked by thomasanderson@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Instrumented libraries: Remove dependence on GYP_DEFINES ========== to ========== Instrumented libraries: Remove dependence on GYP_DEFINES This CL ports download_binaries.py and unpack_binaries.py from using GYP_DEFINES to gn args. Previously, there was a gotcha step where you had to run 'gclient sync' with the right GYP_DEFINES to actually download the prebuilt instrumented libraries. This CL removes that step. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_msan_rel_ng;master.tryserver.chromium.linux:linux_chromium_chromeos_msan_rel_ng R=eugenis@chromium.org ==========
thomasanderson@google.com changed reviewers: + eugenis@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...) android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...) android_cronet on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...) cast_shell_android on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...) linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...) mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
The CQ bit was checked by thomasanderson@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by thomasanderson@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Instrumented libraries: Remove dependence on GYP_DEFINES This CL ports download_binaries.py and unpack_binaries.py from using GYP_DEFINES to gn args. Previously, there was a gotcha step where you had to run 'gclient sync' with the right GYP_DEFINES to actually download the prebuilt instrumented libraries. This CL removes that step. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_msan_rel_ng;master.tryserver.chromium.linux:linux_chromium_chromeos_msan_rel_ng R=eugenis@chromium.org ========== to ========== Instrumented libraries: Remove dependence on GYP_DEFINES This CL ports download_binaries.py and unpack_binaries.py from using GYP_DEFINES to gn args. Previously, there was a gotcha step where you had to run 'gclient sync' with the right GYP_DEFINES to actually download the prebuilt instrumented libraries. This CL removes that step. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_msan_rel_ng;master.tryserver.chromium.linux:linux_chromium_chromeos_msan_rel_ng R=eugenis@chromium.org BUG=705072 ==========
Patchset #1 (id:1) has been deleted
Patchset #1 (id:20001) has been deleted
eugenis ptal The next steps are to 1. remove the DEPS entries in libyuv, pdfium, and v8 2. remove the TODO that I added here 3. remove setting GYP_DEFINES on the msan bots
On 2017/03/24 20:42:31, Tom Anderson wrote: > eugenis ptal > > The next steps are to > 1. remove the DEPS entries in libyuv, pdfium, and v8 > 2. remove the TODO that I added here > 3. remove setting GYP_DEFINES on the msan bots adding to your list, 4. update http://dev.chromium.org/developers/testing/memorysanitizer A very nice cleanup, thank you for doing this! LGTM
The CQ bit was checked by thomasanderson@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by thomasanderson@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from eugenis@chromium.org Link to the patchset: https://codereview.chromium.org/2775913002/#ps60001 (title: "fix python syntax")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1490409565258830,
"parent_rev": "dd51290caf380cdb8b06e02b835e1af436d0c486", "commit_rev":
"5adb8c047852670be6c9d42114f3a17d44b6c56e"}
Message was sent while issue was closed.
Description was changed from ========== Instrumented libraries: Remove dependence on GYP_DEFINES This CL ports download_binaries.py and unpack_binaries.py from using GYP_DEFINES to gn args. Previously, there was a gotcha step where you had to run 'gclient sync' with the right GYP_DEFINES to actually download the prebuilt instrumented libraries. This CL removes that step. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_msan_rel_ng;master.tryserver.chromium.linux:linux_chromium_chromeos_msan_rel_ng R=eugenis@chromium.org BUG=705072 ========== to ========== Instrumented libraries: Remove dependence on GYP_DEFINES This CL ports download_binaries.py and unpack_binaries.py from using GYP_DEFINES to gn args. Previously, there was a gotcha step where you had to run 'gclient sync' with the right GYP_DEFINES to actually download the prebuilt instrumented libraries. This CL removes that step. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_msan_rel_ng;master.tryserver.chromium.linux:linux_chromium_chromeos_msan_rel_ng R=eugenis@chromium.org BUG=705072 Review-Url: https://codereview.chromium.org/2775913002 Cr-Commit-Position: refs/heads/master@{#459630} Committed: https://chromium.googlesource.com/chromium/src/+/5adb8c047852670be6c9d42114f3... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:60001) as https://chromium.googlesource.com/chromium/src/+/5adb8c047852670be6c9d42114f3...
Message was sent while issue was closed.
machenbach@chromium.org changed reviewers: + dpranke@chromium.org, machenbach@chromium.org
Message was sent while issue was closed.
+dpranke https://codereview.chromium.org/2775913002/diff/60001/third_party/instrumente... File third_party/instrumented_libraries/BUILD.gn (right): https://codereview.chromium.org/2775913002/diff/60001/third_party/instrumente... third_party/instrumented_libraries/BUILD.gn:63: tarfile = "$target_out_dir/$tarfile_name" Please note that now different out directories don't share the downloaded binaries anymore. Before they would have. Not sure if that's relevant for those, but I believe that for something like pre-built clang, we couldn't use this logic. https://codereview.chromium.org/2775913002/diff/60001/third_party/instrumente... File third_party/instrumented_libraries/scripts/download_binaries.py (right): https://codereview.chromium.org/2775913002/diff/60001/third_party/instrumente... third_party/instrumented_libraries/scripts/download_binaries.py:7: This script should only be run from gn. Maybe differentiate: It's not run from gn, it's run from ninja. There are scripts run from gn, but those are really called while gn executes, while this script runs as a build target.
Message was sent while issue was closed.
No LGTM. We need to revert this and not take this approach. We must not download things during a build.
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:60001) has been created in https://codereview.chromium.org/2792343003/ by thomasanderson@chromium.org. The reason for reverting is: Reverting now that all of the third_party changes have been reverted. |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
