[ES6 modules] Document ScriptModule

[ES6 modules] Document ScriptModule

BUG=594639
Review-Url: https://codereview.chromium.org/2792263002
Cr-Commit-Position: refs/heads/master@{#461659}
Committed: https://chromium.googlesource.com/chromium/src/+/784c7ca7eb7a7b97cb9d4aa83536a930cec48ba0

[kouhei (in TOK), 2017-04-04 05:26:14]

kouhei@chromium.org changed reviewers:
+ adamk@chromium.org, haraken@chromium.org, yhirano@chromium.org

[haraken, 2017-04-04 05:28:26]

LGTM

https://codereview.chromium.org/2792263002/diff/1/third_party/WebKit/Source/b...
File third_party/WebKit/Source/bindings/core/v8/ScriptModule.h (right):

https://codereview.chromium.org/2792263002/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/bindings/core/v8/ScriptModule.h:23: // we use it to
fill ScriptState in.

Would it be nicer to pass in the ScriptState to ScriptModule's constructor, save
it in ScriptModule's member and then use it for instantiate & evaluate?

[kouhei (in TOK), 2017-04-04 06:39:48]

https://codereview.chromium.org/2792263002/diff/1/third_party/WebKit/Source/b...
File third_party/WebKit/Source/bindings/core/v8/ScriptModule.h (right):

https://codereview.chromium.org/2792263002/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/bindings/core/v8/ScriptModule.h:23: // we use it to
fill ScriptState in.
On 2017/04/04 05:28:26, haraken wrote:
> 
> Would it be nicer to pass in the ScriptState to ScriptModule's constructor,
save
> it in ScriptModule's member and then use it for instantiate & evaluate?

I'd like to try ScriptModule lightweight w/o ScriptState for now, as then
Modulator will have to check ScriptState* is valid every time.

[kouhei (in TOK), 2017-04-04 06:39:53]

The CQ bit was checked by kouhei@chromium.org

[commit-bot: I haz the power, 2017-04-04 06:40:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-04 08:28:10]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1491287993200250, "parent_rev":
"94d7bbdbc5110011a16039c47afa60c4ee065687", "commit_rev":
"784c7ca7eb7a7b97cb9d4aa83536a930cec48ba0"}

[commit-bot: I haz the power, 2017-04-04 08:28:57]

Description was changed from

==========
[ES6 modules] Document ScriptModule

BUG=594639
==========

to

==========
[ES6 modules] Document ScriptModule

BUG=594639

Review-Url: https://codereview.chromium.org/2792263002
Cr-Commit-Position: refs/heads/master@{#461659}
Committed:
https://chromium.googlesource.com/chromium/src/+/784c7ca7eb7a7b97cb9d4aa83536...
==========

[commit-bot: I haz the power, 2017-04-04 08:28:58]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/784c7ca7eb7a7b97cb9d4aa83536...