Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptModule.h

Issue 2792263002: [ES6 modules] Document ScriptModule (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/bindings/core/v8/ScriptModule.h
diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptModule.h b/third_party/WebKit/Source/bindings/core/v8/ScriptModule.h
index fc51232d7f5d635423021db752bd6d01bb9ff217..6180243d642e29793ee4d5802665edae987a2115 100644
--- a/third_party/WebKit/Source/bindings/core/v8/ScriptModule.h
+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptModule.h
@@ -14,6 +14,13 @@
namespace blink {
+// ScriptModule wraps a handle to a v8::Module for use in core.
+//
+// Using ScriptModules needs a ScriptState and its scope to operate in. You
+// should always provide the same ScriptState and not try to reuse ScriptModules
+// across different contexts.
+// Currently all ScriptModule users can easily access its context Modulator, so
+// we use it to fill ScriptState in.
haraken 2017/04/04 05:28:26 Would it be nicer to pass in the ScriptState to Sc
kouhei (in TOK) 2017/04/04 06:39:48 I'd like to try ScriptModule lightweight w/o Scrip
class CORE_EXPORT ScriptModule final {
DISALLOW_NEW_EXCEPT_PLACEMENT_NEW();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698