Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 2792173003: Remove ScopedComPtr::iid() (Closed)

Created:
3 years, 8 months ago by robliao
Modified:
3 years, 8 months ago
CC:
chromium-reviews, grt+watch_chromium.org, danakj+watch_chromium.org, vmpstr+watch_chromium.org, wfh+watch_chromium.org, scottmg
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ScopedComPtr::iid() ComPtr does not expose an iid() method and callers should simply use IID_PPV_ARGS to associate the interface ID with their pointer. BUG=638327 Review-Url: https://codereview.chromium.org/2792173003 Cr-Commit-Position: refs/heads/master@{#462239} Committed: https://chromium.googlesource.com/chromium/src/+/36dfb84d725c4ea00086c1dcb0ae1a83c0eaed25

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -19 lines) Patch
M base/win/scoped_comptr.h View 1 chunk +0 lines, -5 lines 0 comments Download
M base/win/scoped_comptr_unittest.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/google/google_update_win.cc View 3 chunks +7 lines, -11 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 22 (16 generated)
robliao
grt: Please review this CL. Thanks!
3 years, 8 months ago (2017-04-03 22:45:32 UTC) #3
grt (UTC plus 2)
lgtm
3 years, 8 months ago (2017-04-04 11:33:02 UTC) #7
robliao
pkasting: Please review this CL. Thanks!
3 years, 8 months ago (2017-04-04 17:05:20 UTC) #9
Peter Kasting
LGTM
3 years, 8 months ago (2017-04-05 17:26:49 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2792173003/1
3 years, 8 months ago (2017-04-05 21:55:27 UTC) #19
commit-bot: I haz the power
3 years, 8 months ago (2017-04-05 22:08:28 UTC) #22
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/36dfb84d725c4ea00086c1dcb0ae...

Powered by Google App Engine
This is Rietveld 408576698