Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(531)

Issue 2789273002: Add IID_PPV_ARGS_Helper for ScopedComPtr (Closed)

Created:
3 years, 8 months ago by robliao
Modified:
3 years, 8 months ago
Reviewers:
scottmg
CC:
chromium-reviews, grt+watch_chromium.org, danakj+watch_chromium.org, vmpstr+watch_chromium.org, wfh+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add IID_PPV_ARGS_Helper for ScopedComPtr This allows callers to use IID_PPV_ARGS with ScopedComPtr. Also moved some of the internal code to use IID_PPV_ARGS directly. BUG=638327 Review-Url: https://codereview.chromium.org/2789273002 Cr-Commit-Position: refs/heads/master@{#461592} Committed: https://chromium.googlesource.com/chromium/src/+/5a70ea2c136d0004367deeb08dc335ad36772627

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -6 lines) Patch
M base/win/scoped_comptr.h View 5 chunks +11 lines, -4 lines 0 comments Download
M base/win/scoped_comptr_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (8 generated)
robliao
scottmg: Please review this CL. Thanks!
3 years, 8 months ago (2017-04-03 22:32:04 UTC) #3
scottmg
lgtm
3 years, 8 months ago (2017-04-03 22:51:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2789273002/1
3 years, 8 months ago (2017-04-04 00:50:22 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-04 00:59:43 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5a70ea2c136d0004367deeb08dc3...

Powered by Google App Engine
This is Rietveld 408576698