Clean-up in ChildProcessLauncher.

Clean-up in ChildProcessLauncher.

This is a clean-up follow-up for
https://codereview.chromium.org/2760093002:
- the callback type parameter is replaced with the actual callback
  object.
- the alwaysInForeground parameter is now part of the SpawnData class.
- SpawnData accessors are renamed to follow Java naming conventions.

BUG=702316
Review-Url: https://codereview.chromium.org/2792093002
Cr-Commit-Position: refs/heads/master@{#461798}
Committed: https://chromium.googlesource.com/chromium/src/+/dd463aa3da242c236addb4fdf26ee4500bd429f5

[Jay Civelli, 2017-04-03 18:38:37]

Description was changed from

==========
Clean-up in ChildProcessLauncher.

This is a clean-up follow-up for
https://codereview.chromium.org/2760093002

BUG=702316
==========

to

==========
Clean-up in ChildProcessLauncher.

This is a clean-up follow-up for
https://codereview.chromium.org/2760093002:
- the callback type parameter is replaced with the actual callback
  object.
- the alwaysInForeground parameter is now part of the SpawnData class.
- SpawnData accessors are renamed to follow Java naming conventions.

BUG=702316
==========

[Jay Civelli, 2017-04-03 18:38:37]

jcivelli@chromium.org changed reviewers:
+ boliu@chromium.org

[Jay Civelli, 2017-04-03 18:42:06]

The CQ bit was checked by jcivelli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-03 18:43:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-03 19:23:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-03 19:23:29]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Jay Civelli, 2017-04-03 19:39:31]

The CQ bit was checked by jcivelli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-03 19:40:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-03 20:56:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-03 20:56:23]

Dry run: This issue passed the CQ dry run.

[boliu, 2017-04-04 15:57:18]

https://codereview.chromium.org/2792093002/diff/20001/content/public/android/...
File
content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java
(right):

https://codereview.chromium.org/2792093002/diff/20001/content/public/android/...
content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java:664:
&& creationParams == ChildProcessCreationParams.getDefault()) {
should check here that alwaysInForeground matches as well (I guess that check
should have always been there..)

[Jay Civelli, 2017-04-04 16:26:35]

https://codereview.chromium.org/2792093002/diff/20001/content/public/android/...
File
content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java
(right):

https://codereview.chromium.org/2792093002/diff/20001/content/public/android/...
content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java:664:
&& creationParams == ChildProcessCreationParams.getDefault()) {
On 2017/04/04 15:57:18, boliu wrote:
> should check here that alwaysInForeground matches as well (I guess that check
> should have always been there..)

Good catch, done.

[boliu, 2017-04-04 16:28:13]

lgtm

[Jay Civelli, 2017-04-04 16:48:52]

The CQ bit was checked by jcivelli@chromium.org

[commit-bot: I haz the power, 2017-04-04 16:49:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-04 19:19:41]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1491324532633610,
"parent_rev": "f6d347f3fc5dfb79e416719abff15a1d19c81c35", "commit_rev":
"dd463aa3da242c236addb4fdf26ee4500bd429f5"}

[commit-bot: I haz the power, 2017-04-04 19:20:47]

Description was changed from

==========
Clean-up in ChildProcessLauncher.

This is a clean-up follow-up for
https://codereview.chromium.org/2760093002:
- the callback type parameter is replaced with the actual callback
  object.
- the alwaysInForeground parameter is now part of the SpawnData class.
- SpawnData accessors are renamed to follow Java naming conventions.

BUG=702316
==========

to

==========
Clean-up in ChildProcessLauncher.

This is a clean-up follow-up for
https://codereview.chromium.org/2760093002:
- the callback type parameter is replaced with the actual callback
  object.
- the alwaysInForeground parameter is now part of the SpawnData class.
- SpawnData accessors are renamed to follow Java naming conventions.

BUG=702316

Review-Url: https://codereview.chromium.org/2792093002
Cr-Commit-Position: refs/heads/master@{#461798}
Committed:
https://chromium.googlesource.com/chromium/src/+/dd463aa3da242c236addb4fdf26e...
==========

[commit-bot: I haz the power, 2017-04-04 19:20:48]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/dd463aa3da242c236addb4fdf26e...