Making callbacks in Android ChildProcessLauncher generic.

Making callbacks in Android ChildProcessLauncher generic.

As part of the effort of moving ChildProcessLauncher.java to base,
making the callbacks passed to the child processes generic (an IBinder)
and moving the content ones to a specific content class.

BUG=702316
Review-Url: https://codereview.chromium.org/2760093002
Cr-Commit-Position: refs/heads/master@{#458612}
Committed: https://chromium.googlesource.com/chromium/src/+/27d06a66030cece252b659e1eca0be955d4d7475

[Jay Civelli, 2017-03-20 21:18:06]

The CQ bit was checked by jcivelli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-20 21:19:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Jay Civelli, 2017-03-20 21:19:41]

Description was changed from

==========
Making callbacks in Android ChildProcessLauncher generic.

As part of the effort of moving ChildProcessLauncher.java to base,
making the callbacks passed to the child process generic and moving the
content ones to specific content classes.

BUG=702316
==========

to

==========
Making callbacks in Android ChildProcessLauncher generic.

As part of the effort of moving ChildProcessLauncher.java to base,
making the callbacks passed to the child processes generic (an IBinder)
and moving the content ones to a specific content class.

BUG=702316
==========

[Jay Civelli, 2017-03-20 21:25:11]

jcivelli@chromium.org changed reviewers:
+ boliu@chromium.org

[Jay Civelli, 2017-03-20 21:26:03]

jcivelli@chromium.org changed reviewers:
+ yfriedman@chromium.org

[boliu, 2017-03-20 22:39:16]

https://codereview.chromium.org/2760093002/diff/1/content/public/android/java...
File
content/public/android/java/src/org/chromium/content/common/IContentChildProcessCallback.aidl
(right):

https://codereview.chromium.org/2760093002/diff/1/content/public/android/java...
content/public/android/java/src/org/chromium/content/common/IContentChildProcessCallback.aidl:10:
interface IContentChildProcessCallback {
Let's bikeshed the name.. this is now only about Surfaces, so maybe something
surface related? Err... SurfaceChannel?

[Jay Civelli, 2017-03-20 22:41:57]

https://codereview.chromium.org/2760093002/diff/1/content/public/android/java...
File
content/public/android/java/src/org/chromium/content/common/IContentChildProcessCallback.aidl
(right):

https://codereview.chromium.org/2760093002/diff/1/content/public/android/java...
content/public/android/java/src/org/chromium/content/common/IContentChildProcessCallback.aidl:10:
interface IContentChildProcessCallback {
On 2017/03/20 22:39:16, boliu wrote:
> Let's bikeshed the name.. this is now only about Surfaces, so maybe something
> surface related? Err... SurfaceChannel?

Actually I was thinking about this when I sent it for review.
My take is that it's the callbacks for the GPU process, since it's process
specific maybe IGpuProcessCallbacks?
WDYT?

[boliu, 2017-03-20 22:45:48]

https://codereview.chromium.org/2760093002/diff/1/content/public/android/java...
File
content/public/android/java/src/org/chromium/content/common/IContentChildProcessCallback.aidl
(right):

https://codereview.chromium.org/2760093002/diff/1/content/public/android/java...
content/public/android/java/src/org/chromium/content/common/IContentChildProcessCallback.aidl:10:
interface IContentChildProcessCallback {
On 2017/03/20 22:41:57, Jay Civelli wrote:
> On 2017/03/20 22:39:16, boliu wrote:
> > Let's bikeshed the name.. this is now only about Surfaces, so maybe
something
> > surface related? Err... SurfaceChannel?
> 
> Actually I was thinking about this when I sent it for review.
> My take is that it's the callbacks for the GPU process, since it's process
> specific maybe IGpuProcessCallbacks?
> WDYT?

sgtm

[commit-bot: I haz the power, 2017-03-20 22:54:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-20 22:54:22]

Dry run: This issue passed the CQ dry run.

[Jay Civelli, 2017-03-20 23:35:05]

On 2017/03/20 22:45:48, boliu wrote:
>
https://codereview.chromium.org/2760093002/diff/1/content/public/android/java...
> File
>
content/public/android/java/src/org/chromium/content/common/IContentChildProcessCallback.aidl
> (right):
> 
>
https://codereview.chromium.org/2760093002/diff/1/content/public/android/java...
>
content/public/android/java/src/org/chromium/content/common/IContentChildProcessCallback.aidl:10:
> interface IContentChildProcessCallback {
> On 2017/03/20 22:41:57, Jay Civelli wrote:
> > On 2017/03/20 22:39:16, boliu wrote:
> > > Let's bikeshed the name.. this is now only about Surfaces, so maybe
> something
> > > surface related? Err... SurfaceChannel?
> > 
> > Actually I was thinking about this when I sent it for review.
> > My take is that it's the callbacks for the GPU process, since it's process
> > specific maybe IGpuProcessCallbacks?
> > WDYT?
> 
> sgtm

Done.

[Jay Civelli, 2017-03-20 23:35:10]

The CQ bit was checked by jcivelli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-20 23:36:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[boliu, 2017-03-21 00:02:50]

lgtm

[commit-bot: I haz the power, 2017-03-21 01:18:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-21 01:18:12]

Dry run: This issue passed the CQ dry run.

[Yaron, 2017-03-21 16:13:56]

lgtm

https://codereview.chromium.org/2760093002/diff/20001/content/public/android/...
File
content/public/android/java/src/org/chromium/content/app/ChildProcessServiceImpl.java
(right):

https://codereview.chromium.org/2760093002/diff/20001/content/public/android/...
content/public/android/java/src/org/chromium/content/app/ChildProcessServiceImpl.java:141:
callback != null ? IGpuProcessCallback.Stub.asInterface(callback) : null;
Seems a little dangerous to assume the cast will just work. I guess it's not
really worse than before when we created the callback unconditionally but only
used it for gpu

[Jay Civelli, 2017-03-21 16:20:22]

The CQ bit was checked by jcivelli@chromium.org

[commit-bot: I haz the power, 2017-03-21 16:20:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-21 16:28:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-21 16:28:37]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Jay Civelli, 2017-03-21 17:04:23]

The CQ bit was checked by jcivelli@chromium.org

[Jay Civelli, 2017-03-21 17:04:24]

The patchset sent to the CQ was uploaded after l-g-t-m from
yfriedman@chromium.org, boliu@chromium.org
Link to the patchset: https://codereview.chromium.org/2760093002/#ps40001
(title: "Synced")

[commit-bot: I haz the power, 2017-03-21 17:04:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-21 17:15:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-21 17:15:56]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Jay Civelli, 2017-03-21 18:23:35]

jcivelli@chromium.org changed reviewers:
+ palmer@chromium.org

[Jay Civelli, 2017-03-21 18:24:13]

Adding palmer@ for security OWNERS review of AIDL files.

[palmer, 2017-03-21 19:08:09]

lgtm

[Jay Civelli, 2017-03-21 22:03:44]

The CQ bit was checked by jcivelli@chromium.org

[Jay Civelli, 2017-03-21 22:03:45]

The patchset sent to the CQ was uploaded after l-g-t-m from palmer@chromium.org,
yfriedman@chromium.org, boliu@chromium.org
Link to the patchset: https://codereview.chromium.org/2760093002/#ps60001
(title: "Synced")

[commit-bot: I haz the power, 2017-03-21 22:04:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-22 01:40:41]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1490133824633660,
"parent_rev": "fe4511af4dbe67fe6f946fd9ae34fecb4ff5dbe4", "commit_rev":
"27d06a66030cece252b659e1eca0be955d4d7475"}

[commit-bot: I haz the power, 2017-03-22 01:41:50]

Description was changed from

==========
Making callbacks in Android ChildProcessLauncher generic.

As part of the effort of moving ChildProcessLauncher.java to base,
making the callbacks passed to the child processes generic (an IBinder)
and moving the content ones to a specific content class.

BUG=702316
==========

to

==========
Making callbacks in Android ChildProcessLauncher generic.

As part of the effort of moving ChildProcessLauncher.java to base,
making the callbacks passed to the child processes generic (an IBinder)
and moving the content ones to a specific content class.

BUG=702316

Review-Url: https://codereview.chromium.org/2760093002
Cr-Commit-Position: refs/heads/master@{#458612}
Committed:
https://chromium.googlesource.com/chromium/src/+/27d06a66030cece252b659e1eca0...
==========

[commit-bot: I haz the power, 2017-03-22 01:41:57]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/27d06a66030cece252b659e1eca0...