Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Side by Side Diff: content/public/android/javatests/src/org/chromium/content/browser/ChildProcessLauncherTest.java

Issue 2792093002: Clean-up in ChildProcessLauncher. (Closed)
Patch Set: Addressed boliu@'s comment Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 package org.chromium.content.browser; 5 package org.chromium.content.browser;
6 6
7 import android.content.ComponentName; 7 import android.content.ComponentName;
8 import android.content.Context; 8 import android.content.Context;
9 import android.content.Intent; 9 import android.content.Intent;
10 import android.content.ServiceConnection; 10 import android.content.ServiceConnection;
(...skipping 519 matching lines...) Expand 10 before | Expand all | Expand 10 after
530 return ChildProcessLauncher.allocatedSandboxedConnectionsCountForTesting ( 530 return ChildProcessLauncher.allocatedSandboxedConnectionsCountForTesting (
531 context, context.getPackageName()); 531 context, context.getPackageName());
532 } 532 }
533 533
534 private ChildProcessCreationParams getDefaultChildProcessCreationParams(Stri ng packageName) { 534 private ChildProcessCreationParams getDefaultChildProcessCreationParams(Stri ng packageName) {
535 return new ChildProcessCreationParams(packageName, false /* isExternalSe rvice */, 535 return new ChildProcessCreationParams(packageName, false /* isExternalSe rvice */,
536 LibraryProcessType.PROCESS_CHILD); 536 LibraryProcessType.PROCESS_CHILD);
537 } 537 }
538 538
539 private void triggerConnectionSetup(ChildProcessConnectionImpl connection) { 539 private void triggerConnectionSetup(ChildProcessConnectionImpl connection) {
540 ChildProcessLauncher.triggerConnectionSetup(connection, sProcessWaitArgu ments, 1, 540 ChildProcessLauncher.triggerConnectionSetup(connection, sProcessWaitArgu ments,
541 new FileDescriptorInfo[0], ChildProcessLauncher.CALLBACK_FOR_REN DERER_PROCESS, 541 1 /* childProcessId */, new FileDescriptorInfo[0], null /* launc hCallback */,
542 null); 542 null /* childProcessCallback */);
543 } 543 }
544 } 544 }
OLDNEW
« no previous file with comments | « content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698