Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 2792063002: Reland of Skip paint property update and visual rect update if no geometry change (Closed)

Created:
3 years, 8 months ago by Xianzhu
Modified:
3 years, 8 months ago
Reviewers:
pdr., chrishtr, Timothy Loh
CC:
ajuma+watch-canvas_chromium.org, blink-reviews, blink-reviews-frames_chromium.org, blink-reviews-html_chromium.org, blink-reviews-layout_chromium.org, blink-reviews-paint_chromium.org, Rik, chromium-reviews, dglazkov+blink, dshwang, krit, eae+blinkwatch, fmalita+watch_chromium.org, fs, gyuyoung2, jchaffraix+rendering, Justin Novosad, kinuko+watch, kouhei+svg_chromium.org, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Skip paint property update and visual rect update if no geometry change (patchset #1 id:1 of https://codereview.chromium.org/2792863002/ ) Reland after https://codereview.chromium.org/2791933003/ which fixed the layout test failures (about overflow recalc). Also fixed a bug of false-negative of visual rect change in FindPaintOffsetAndVisualRectNeedingUpdate.h. Original issue's description: > Revert of Skip paint property update and visual rect update if no geometry change (patchset #25 id:480001 of https://codereview.chromium.org/2732573003/ ) > > Reason for revert: > Looks like this is making tests fail on most builders, e.g. > > https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty/builds/25101 > > Original issue's description: > > Skip paint property update and visual rect update if no geometry change > > > > This avoids unnecessary visual rect computation and update of paint > > offset related paint properties. > > > > BUG=697081, 685179 > > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > > > > Review-Url: https://codereview.chromium.org/2732573003 > > Cr-Commit-Position: refs/heads/master@{#461348} > > Committed: https://chromium.googlesource.com/chromium/src/+/81f28ed19f771fe93406496d1d23da137abcd602 > > TBR=pdr@chromium.org,chrishtr@chromium.org,wangxianzhu@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=697081, 685179 > > Review-Url: https://codereview.chromium.org/2792863002 > Cr-Commit-Position: refs/heads/master@{#461357} > Committed: https://chromium.googlesource.com/chromium/src/+/6d954094c746673d37970ab1321e810622c8fd49 TBR=pdr@chromium.org BUG=697081, 685179 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2792063002 Cr-Commit-Position: refs/heads/master@{#461885} Committed: https://chromium.googlesource.com/chromium/src/+/d2819bd5ebfb32f0866d92ad6e62a45499e05517

Patch Set 1 #

Patch Set 2 : - #

Patch Set 3 : Rebase on https://codereview.chromium.org/2791933003/ #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+443 lines, -148 lines) Patch
M third_party/WebKit/Source/core/editing/CaretDisplayItemClient.cpp View 1 2 chunks +17 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameView.cpp View 1 2 3 2 chunks +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.h View 1 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/PaintInvalidationState.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/PaintInvalidationState.cpp View 1 2 3 1 chunk +1 line, -8 lines 0 comments Download
A third_party/WebKit/Source/core/paint/FindPaintOffsetAndVisualRectNeedingUpdate.h View 1 2 1 chunk +181 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/FindPropertiesNeedingUpdate.h View 1 4 chunks +21 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/paint/ObjectPaintInvalidator.cpp View 1 4 chunks +18 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintInvalidationCapableScrollableArea.cpp View 1 4 chunks +15 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintInvalidator.h View 1 2 3 4 chunks +26 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintInvalidator.cpp View 1 2 3 11 chunks +66 lines, -63 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.h View 1 2 chunks +8 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp View 1 2 3 2 chunks +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PrePaintTreeWalk.h View 1 2 3 1 chunk +6 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PrePaintTreeWalk.cpp View 1 2 3 5 chunks +68 lines, -33 lines 0 comments Download

Messages

Total messages: 14 (11 generated)
Xianzhu
Created Reland of Skip paint property update and visual rect update if no geometry change
3 years, 8 months ago (2017-04-03 16:59:51 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2792063002/270001
3 years, 8 months ago (2017-04-04 21:23:16 UTC) #11
commit-bot: I haz the power
3 years, 8 months ago (2017-04-04 23:14:22 UTC) #14
Message was sent while issue was closed.
Committed patchset #4 (id:270001) as
https://chromium.googlesource.com/chromium/src/+/d2819bd5ebfb32f0866d92ad6e62...

Powered by Google App Engine
This is Rietveld 408576698