Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1277)

Unified Diff: services/preferences/public/cpp/pref_store_client_mixin.cc

Issue 2791893002: Pref service: Batch pref updates. (Closed)
Patch Set: rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: services/preferences/public/cpp/pref_store_client_mixin.cc
diff --git a/services/preferences/public/cpp/pref_store_client_mixin.cc b/services/preferences/public/cpp/pref_store_client_mixin.cc
index a82108a1d41fce48b601928cdee6a61369baa24b..0387883265f206a0a0e34b1c0f981b34f923f239 100644
--- a/services/preferences/public/cpp/pref_store_client_mixin.cc
+++ b/services/preferences/public/cpp/pref_store_client_mixin.cc
@@ -82,6 +82,23 @@ void PrefStoreClientMixin<BasePrefStore>::ReportPrefValueChanged(
}
template <typename BasePrefStore>
+void PrefStoreClientMixin<BasePrefStore>::OnPrefsChanged(
+ std::vector<mojom::PrefUpdatePtr> updates) {
+ for (const auto& update : updates)
+ OnPrefChanged(update->key, std::move(update->value));
+}
+
+template <typename BasePrefStore>
+void PrefStoreClientMixin<BasePrefStore>::OnInitializationCompleted(
+ bool succeeded) {
+ if (!initialized_) {
+ initialized_ = true;
+ for (auto& observer : observers_)
+ observer.OnInitializationCompleted(succeeded);
+ }
+}
+
+template <typename BasePrefStore>
void PrefStoreClientMixin<BasePrefStore>::OnPrefChanged(
const std::string& key,
std::unique_ptr<base::Value> value) {
@@ -106,16 +123,6 @@ void PrefStoreClientMixin<BasePrefStore>::OnPrefChanged(
ReportPrefValueChanged(key);
}
-template <typename BasePrefStore>
-void PrefStoreClientMixin<BasePrefStore>::OnInitializationCompleted(
- bool succeeded) {
- if (!initialized_) {
- initialized_ = true;
- for (auto& observer : observers_)
- observer.OnInitializationCompleted(succeeded);
- }
-}
-
template class PrefStoreClientMixin<::PrefStore>;
template class PrefStoreClientMixin<::PersistentPrefStore>;
« no previous file with comments | « services/preferences/public/cpp/pref_store_client_mixin.h ('k') | services/preferences/public/cpp/pref_store_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698