Pref service: Batch pref updates.

services/preferences/persistent_pref_store_impl.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "services/preferences/persistent_pref_store_impl.h"
 
 #include <utility>
 
 #include "base/auto_reset.h"
 #include "base/memory/ptr_util.h"
@@ skipping 16 matching lines @@
         observed_keys_(std::move(observed_keys)) {
     auto error_callback =
         base::Bind(&PersistentPrefStoreImpl::Connection::OnConnectionError,
                    base::Unretained(this));
     binding_.set_connection_error_handler(error_callback);
     observer_.set_connection_error_handler(error_callback);
   }
 
   ~Connection() override = default;
 
-  void OnPrefValueChanged(const std::string& key, const base::Value* value) {
-    if (write_in_progress_ || !base::ContainsKey(observed_keys_, key))
+  void OnPrefValuesChanged(const std::vector<mojom::PrefUpdatePtr>& updates) {
+    if (write_in_progress_)
       return;
 
-    observer_->OnPrefChanged(key, value ? value->CreateDeepCopy() : nullptr);
+    std::vector<mojom::PrefUpdatePtr> filtered_updates;
+    for (const auto& update : updates) {
+      if (base::ContainsKey(observed_keys_, update->key)) {
+        filtered_updates.push_back(mojom::PrefUpdate::New(
+            update->key,
+            update->value ? update->value->CreateDeepCopy() : nullptr, 0));
+      }
+    }
+    if (!filtered_updates.empty())
+      observer_->OnPrefsChanged(std::move(filtered_updates));
   }
 
  private:
   // mojom::PersistentPrefStore:
-  void SetValue(const std::string& key,
-                std::unique_ptr<base::Value> value,
-                uint32_t flags) override {
+  void SetValues(std::vector<mojom::PrefUpdatePtr> updates) override {
     base::AutoReset<bool> scoped_call_in_progress(&write_in_progress_, true);
-    pref_store_->SetValue(key, std::move(value), flags);
+    pref_store_->SetValues(std::move(updates));
   }
 
   void CommitPendingWrite() override { pref_store_->CommitPendingWrite(); }
   void SchedulePendingLossyWrites() override {
     pref_store_->SchedulePendingLossyWrites();
   }
   void ClearMutableValues() override { pref_store_->ClearMutableValues(); }
 
   void OnConnectionError() { pref_store_->OnConnectionError(this); }
 
   // Owns |this|.
   PersistentPrefStoreImpl* const pref_store_;
 
   mojo::Binding<mojom::PersistentPrefStore> binding_;
   mojom::PrefStoreObserverPtr observer_;
   const ObservedPrefs observed_keys_;
 
   // If true then a write is in progress and any update notifications should be
   // ignored, as those updates would originate from ourselves.
   bool write_in_progress_ = false;
 
   DISALLOW_COPY_AND_ASSIGN(Connection);
 };
 
 PersistentPrefStoreImpl::PersistentPrefStoreImpl(
     scoped_refptr<PersistentPrefStore> backing_pref_store,
     base::OnceClosure on_initialized)
     : backing_pref_store_(backing_pref_store) {
-  backing_pref_store_->AddObserver(this);
   if (!backing_pref_store_->IsInitializationComplete()) {
+    backing_pref_store_->AddObserver(this);
     on_initialized_ = std::move(on_initialized);
     initializing_ = true;
     backing_pref_store_->ReadPrefsAsync(nullptr);
   }
 }
 
-PersistentPrefStoreImpl::~PersistentPrefStoreImpl() {
-  backing_pref_store_->RemoveObserver(this);
-}
+PersistentPrefStoreImpl::~PersistentPrefStoreImpl() = default;
 
 mojom::PersistentPrefStoreConnectionPtr
 PersistentPrefStoreImpl::CreateConnection(ObservedPrefs observed_prefs) {
   DCHECK(!initializing_);
   if (!backing_pref_store_->IsInitializationComplete()) {
     // |backing_pref_store_| initialization failed.
     return mojom::PersistentPrefStoreConnection::New(
         nullptr, nullptr, backing_pref_store_->GetReadError(),
         backing_pref_store_->ReadOnly());
   }
   mojom::PersistentPrefStorePtr pref_store_ptr;
   mojom::PrefStoreObserverPtr observer;
   mojom::PrefStoreObserverRequest observer_request =
       mojo::MakeRequest(&observer);
   auto connection = base::MakeUnique<Connection>(
       this, mojo::MakeRequest(&pref_store_ptr), std::move(observer),
       std::move(observed_prefs));
   auto* connection_ptr = connection.get();
   connections_.insert(std::make_pair(connection_ptr, std::move(connection)));
   return mojom::PersistentPrefStoreConnection::New(
       mojom::PrefStoreConnection::New(std::move(observer_request),
                                       backing_pref_store_->GetValues(), true),
       std::move(pref_store_ptr), backing_pref_store_->GetReadError(),
       backing_pref_store_->ReadOnly());
 }
 
-void PersistentPrefStoreImpl::OnPrefValueChanged(const std::string& key) {
-  // All mutations are triggered by a client. Updates are only sent to clients
-  // other than the instigator so if there is only one client, it will ignore
-  // the update.
-  if (connections_.size() == 1)
-    return;
-
-  const base::Value* value = nullptr;
-  backing_pref_store_->GetValue(key, &value);
-  for (auto& entry : connections_)
-    entry.first->OnPrefValueChanged(key, value);
-}
+void PersistentPrefStoreImpl::OnPrefValueChanged(const std::string& key) {}
 
 void PersistentPrefStoreImpl::OnInitializationCompleted(bool succeeded) {
   DCHECK(initializing_);
+  backing_pref_store_->RemoveObserver(this);
   initializing_ = false;
   std::move(on_initialized_).Run();
 }
 
-void PersistentPrefStoreImpl::SetValue(const std::string& key,
-                                       std::unique_ptr<base::Value> value,
-                                       uint32_t flags) {
-  if (value)
-    backing_pref_store_->SetValue(key, std::move(value), flags);
-  else
-    backing_pref_store_->RemoveValue(key, flags);
+void PersistentPrefStoreImpl::SetValues(
+    std::vector<mojom::PrefUpdatePtr> updates) {
+  for (auto& entry : connections_)
+    entry.first->OnPrefValuesChanged(updates);
+
+  for (auto& update : updates) {
+    if (update->value) {
+      backing_pref_store_->SetValue(update->key, std::move(update->value),
+                                    update->flags);
+    } else {
+      backing_pref_store_->RemoveValue(update->key, update->flags);
+    }
+  }
 }
 
 void PersistentPrefStoreImpl::CommitPendingWrite() {
   backing_pref_store_->CommitPendingWrite();
 }
 
 void PersistentPrefStoreImpl::SchedulePendingLossyWrites() {
   backing_pref_store_->SchedulePendingLossyWrites();
 }
 
 void PersistentPrefStoreImpl::ClearMutableValues() {
   backing_pref_store_->ClearMutableValues();
 }
 
 void PersistentPrefStoreImpl::OnConnectionError(Connection* connection) {
   connections_.erase(connection);
 }
 
 }  // namespace prefs