Issue 2791863002: Fix deps reading_list_remover_helper -> dom_distiller

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2791863002: Fix deps reading_list_remover_helper -> dom_distiller (Closed)

Created:
3 years, 8 months ago by Olivier

Modified:
3 years, 8 months ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/branch-heads/3029

Project:
chromium

Visibility:
Public.

Fix deps reading_list_remover_helper -> dom_distiller The dom_distiller export a protobuf header and must be declared as public deps. BUG=705890 Review-Url: https://codereview.chromium.org/2772373004 Cr-Commit-Position: refs/heads/master@{#460073} (cherry picked from commit 03b5ef86dce1b086e2fb8b5434e523e0d9b473e3) Review-Url: https://codereview.chromium.org/2791863002 . Cr-Commit-Position: refs/branch-heads/3029@{#525} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/c5db9b7276b3d40ceda37b6c36ea96e9d4389bc6

Created: 3 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -0 lines)			Patch
	M	ios/chrome/browser/reading_list/BUILD.gn	View		1 chunk	+8 lines, -0 lines	0 comments	Download

Total messages: 2 (1 generated)

Olivier

3 years, 8 months ago (2017-04-01 05:28:19 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
c5db9b7276b3d40ceda37b6c36ea96e9d4389bc6.