Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Side by Side Diff: ios/chrome/browser/reading_list/BUILD.gn

Issue 2791863002: Fix deps reading_list_remover_helper -> dom_distiller (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2016 The Chromium Authors. All rights reserved. 1 # Copyright 2016 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 source_set("reading_list") { 5 source_set("reading_list") {
6 configs += [ "//build/config/compiler:enable_arc" ] 6 configs += [ "//build/config/compiler:enable_arc" ]
7 sources = [ 7 sources = [
8 "favicon_web_state_dispatcher_impl.h", 8 "favicon_web_state_dispatcher_impl.h",
9 "favicon_web_state_dispatcher_impl.mm", 9 "favicon_web_state_dispatcher_impl.mm",
10 "offline_url_utils.cc", 10 "offline_url_utils.cc",
(...skipping 47 matching lines...) Expand 10 before | Expand all | Expand 10 after
58 source_set("reading_list_remover") { 58 source_set("reading_list_remover") {
59 sources = [ 59 sources = [
60 "reading_list_remover_helper.cc", 60 "reading_list_remover_helper.cc",
61 "reading_list_remover_helper.h", 61 "reading_list_remover_helper.h",
62 ] 62 ]
63 deps = [ 63 deps = [
64 "//base", 64 "//base",
65 "//components/reading_list/ios", 65 "//components/reading_list/ios",
66 "//ios/chrome/browser/browser_state", 66 "//ios/chrome/browser/browser_state",
67 ] 67 ]
68 public_deps = [
69 # This is required because this target includes
70 # reading_list_download_service.h from :reading_list that includes
71 # a protobuf header from dom_distiller.
72 # the inclusion of reading_list_download_service.h is allowed using
73 # allow_circular_includes_from.
74 "//ios/chrome/browser/dom_distiller",
75 ]
68 } 76 }
69 77
70 source_set("unit_tests") { 78 source_set("unit_tests") {
71 configs += [ "//build/config/compiler:enable_arc" ] 79 configs += [ "//build/config/compiler:enable_arc" ]
72 testonly = true 80 testonly = true
73 sources = [ 81 sources = [
74 "favicon_web_state_dispatcher_impl_unittest.mm", 82 "favicon_web_state_dispatcher_impl_unittest.mm",
75 "offline_url_utils_unittest.cc", 83 "offline_url_utils_unittest.cc",
76 "reading_list_web_state_observer_unittest.mm", 84 "reading_list_web_state_observer_unittest.mm",
77 "url_downloader_unittest.mm", 85 "url_downloader_unittest.mm",
78 ] 86 ]
79 deps = [ 87 deps = [
80 ":reading_list", 88 ":reading_list",
81 "//base", 89 "//base",
82 "//base/test:test_support", 90 "//base/test:test_support",
83 "//components/favicon/ios", 91 "//components/favicon/ios",
84 "//components/reading_list/ios", 92 "//components/reading_list/ios",
85 "//ios/chrome/browser", 93 "//ios/chrome/browser",
86 "//ios/chrome/browser/browser_state:test_support", 94 "//ios/chrome/browser/browser_state:test_support",
87 "//ios/chrome/browser/dom_distiller", 95 "//ios/chrome/browser/dom_distiller",
88 "//ios/testing:ios_test_support", 96 "//ios/testing:ios_test_support",
89 "//ios/web", 97 "//ios/web",
90 "//ios/web:test_support", 98 "//ios/web:test_support",
91 "//net", 99 "//net",
92 "//testing/gtest", 100 "//testing/gtest",
93 "//url", 101 "//url",
94 ] 102 ]
95 } 103 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698