Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Issue 2772373004: Fix deps reading_list_remover_helper -> dom_distiller (Closed)

Created:
3 years, 9 months ago by Olivier
Modified:
3 years, 8 months ago
Reviewers:
sdefresne
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, marq+watch_chromium.org, stkhapugin, sdefresne+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix deps reading_list_remover_helper -> dom_distiller The dom_distiller export a protobuf header and must be declared as public deps. BUG=705890 Review-Url: https://codereview.chromium.org/2772373004 Cr-Commit-Position: refs/heads/master@{#460073} Committed: https://chromium.googlesource.com/chromium/src/+/03b5ef86dce1b086e2fb8b5434e523e0d9b473e3

Patch Set 1 #

Total comments: 2

Patch Set 2 : add comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M ios/chrome/browser/reading_list/BUILD.gn View 1 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Olivier
3 years, 9 months ago (2017-03-28 08:37:28 UTC) #2
sdefresne
lgtm https://codereview.chromium.org/2772373004/diff/1/ios/chrome/browser/reading_list/BUILD.gn File ios/chrome/browser/reading_list/BUILD.gn (right): https://codereview.chromium.org/2772373004/diff/1/ios/chrome/browser/reading_list/BUILD.gn#newcode69 ios/chrome/browser/reading_list/BUILD.gn:69: public_deps = [ lgtm, but can you add ...
3 years, 9 months ago (2017-03-28 08:57:21 UTC) #3
Olivier
https://codereview.chromium.org/2772373004/diff/1/ios/chrome/browser/reading_list/BUILD.gn File ios/chrome/browser/reading_list/BUILD.gn (right): https://codereview.chromium.org/2772373004/diff/1/ios/chrome/browser/reading_list/BUILD.gn#newcode69 ios/chrome/browser/reading_list/BUILD.gn:69: public_deps = [ On 2017/03/28 08:57:21, sdefresne wrote: > ...
3 years, 9 months ago (2017-03-28 11:46:51 UTC) #4
Olivier
Thanks!
3 years, 9 months ago (2017-03-28 11:47:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2772373004/20001
3 years, 9 months ago (2017-03-28 11:47:28 UTC) #8
commit-bot: I haz the power
3 years, 8 months ago (2017-03-28 12:50:04 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/03b5ef86dce1b086e2fb8b5434e5...

Powered by Google App Engine
This is Rietveld 408576698