Make CompositorObserver’s destructor protected-and-virtual.

Make CompositorObserver’s destructor virtual.

Typically all *Observers have their destructors virtual,
but CompositorObserver was not consistent with that.

BUG=None

Review-Url: https://codereview.chromium.org/2791613002
Cr-Commit-Position: refs/heads/master@{#461806}
Committed: https://chromium.googlesource.com/chromium/src/+/6a474c2a4eb3a3c1c8913547c6ce2e314238ceeb

[themblsha, 2017-03-31 14:51:48]

Description was changed from

==========
Make CompositorObserver’s destructor protected-and-virtual.

Typically all *Observers have their destructors protected and virtual,
but CompositorObserver was not consistent with that.

BUG=None
==========

to

==========
Make CompositorObserver’s destructor protected-and-virtual.

Typically all *Observers have their destructors protected and virtual,
but CompositorObserver was not consistent with that.

BUG=None
==========

[themblsha, 2017-03-31 14:51:48]

mblsha@yandex-team.ru changed reviewers:
+ ccameron@chromium.org, danakj@chromium.org

[themblsha, 2017-03-31 14:53:15]

https://codereview.chromium.org/2779753008/ — neptr couldn't finish the work in
time so the torch was passed to me instead.

[danakj, 2017-03-31 14:56:54]

Update the patch description, it's not making it protected and there's no reason
to

https://codereview.chromium.org/2791613002/diff/1/ui/compositor/compositor_ob...
File ui/compositor/compositor_observer.h (right):

https://codereview.chromium.org/2791613002/diff/1/ui/compositor/compositor_ob...
ui/compositor/compositor_observer.h:42: virtual ~CompositorObserver() {}
Destructors go first in the class

[themblsha, 2017-03-31 15:13:37]

Description was changed from

==========
Make CompositorObserver’s destructor protected-and-virtual.

Typically all *Observers have their destructors protected and virtual,
but CompositorObserver was not consistent with that.

BUG=None
==========

to

==========
Make CompositorObserver’s destructor virtual.

Typically all *Observers have their destructors virtual,
but CompositorObserver was not consistent with that.

BUG=None
==========

[themblsha, 2017-03-31 15:21:52]

https://codereview.chromium.org/2791613002/diff/1/ui/compositor/compositor_ob...
File ui/compositor/compositor_observer.h (right):

https://codereview.chromium.org/2791613002/diff/1/ui/compositor/compositor_ob...
ui/compositor/compositor_observer.h:42: virtual ~CompositorObserver() {}
On 2017/03/31 14:56:54, danakj wrote:
> Destructors go first in the class

Done.

[danakj, 2017-03-31 18:09:42]

LGTM

https://codereview.chromium.org/2791613002/diff/20001/ui/compositor/composito...
File ui/compositor/compositor_observer.h (right):

https://codereview.chromium.org/2791613002/diff/20001/ui/compositor/composito...
ui/compositor/compositor_observer.h:18: virtual ~CompositorObserver() {}
Thanks, you can use "= default;" instead of "{}" now also

[ccameron, 2017-03-31 18:54:59]

.mm lgtm

[themblsha, 2017-04-04 17:52:08]

https://codereview.chromium.org/2791613002/diff/20001/ui/compositor/composito...
File ui/compositor/compositor_observer.h (right):

https://codereview.chromium.org/2791613002/diff/20001/ui/compositor/composito...
ui/compositor/compositor_observer.h:18: virtual ~CompositorObserver() {}
On 2017/03/31 18:09:42, danakj wrote:
> Thanks, you can use "= default;" instead of "{}" now also

Done.

[themblsha, 2017-04-04 17:52:13]

The CQ bit was checked by mblsha@yandex-team.ru

[themblsha, 2017-04-04 17:52:13]

The patchset sent to the CQ was uploaded after l-g-t-m from danakj@chromium.org,
ccameron@chromium.org
Link to the patchset: https://codereview.chromium.org/2791613002/#ps40001
(title: "{} --> default")

[commit-bot: I haz the power, 2017-04-04 17:52:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-04 20:01:29]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1491328333008540,
"parent_rev": "cfd7ac54e35e10f6d52546e18b97e39477eb8013", "commit_rev":
"6a474c2a4eb3a3c1c8913547c6ce2e314238ceeb"}

[commit-bot: I haz the power, 2017-04-04 20:02:21]

Description was changed from

==========
Make CompositorObserver’s destructor virtual.

Typically all *Observers have their destructors virtual,
but CompositorObserver was not consistent with that.

BUG=None
==========

to

==========
Make CompositorObserver’s destructor virtual.

Typically all *Observers have their destructors virtual,
but CompositorObserver was not consistent with that.

BUG=None

Review-Url: https://codereview.chromium.org/2791613002
Cr-Commit-Position: refs/heads/master@{#461806}
Committed:
https://chromium.googlesource.com/chromium/src/+/6a474c2a4eb3a3c1c8913547c6ce...
==========

[commit-bot: I haz the power, 2017-04-04 20:02:23]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/6a474c2a4eb3a3c1c8913547c6ce...