Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Side by Side Diff: ui/compositor/compositor_observer.h

Issue 2791613002: Make CompositorObserver’s destructor protected-and-virtual. (Closed)
Patch Set: Move destructor to the front of class. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef UI_COMPOSITOR_COMPOSITOR_OBSERVER_H_ 5 #ifndef UI_COMPOSITOR_COMPOSITOR_OBSERVER_H_
6 #define UI_COMPOSITOR_COMPOSITOR_OBSERVER_H_ 6 #define UI_COMPOSITOR_COMPOSITOR_OBSERVER_H_
7 7
8 #include "base/time/time.h" 8 #include "base/time/time.h"
9 #include "ui/compositor/compositor_export.h" 9 #include "ui/compositor/compositor_export.h"
10 10
11 namespace ui { 11 namespace ui {
12 12
13 class Compositor; 13 class Compositor;
14 14
15 // A compositor observer is notified when compositing completes. 15 // A compositor observer is notified when compositing completes.
16 class COMPOSITOR_EXPORT CompositorObserver { 16 class COMPOSITOR_EXPORT CompositorObserver {
17 public: 17 public:
18 virtual ~CompositorObserver() {}
danakj 2017/03/31 18:09:42 Thanks, you can use "= default;" instead of "{}" n
themblsha 2017/04/04 17:52:08 Done.
19
18 // A commit proxies information from the main thread to the compositor 20 // A commit proxies information from the main thread to the compositor
19 // thread. It typically happens when some state changes that will require a 21 // thread. It typically happens when some state changes that will require a
20 // composite. In the multi-threaded case, many commits may happen between 22 // composite. In the multi-threaded case, many commits may happen between
21 // two successive composites. In the single-threaded, a single commit 23 // two successive composites. In the single-threaded, a single commit
22 // between two composites (just before the composite as part of the 24 // between two composites (just before the composite as part of the
23 // composite cycle). If the compositor is locked, it will not send this 25 // composite cycle). If the compositor is locked, it will not send this
24 // this signal. 26 // this signal.
25 virtual void OnCompositingDidCommit(Compositor* compositor) = 0; 27 virtual void OnCompositingDidCommit(Compositor* compositor) = 0;
26 28
27 // Called when compositing started: it has taken all the layer changes into 29 // Called when compositing started: it has taken all the layer changes into
28 // account and has issued the graphics commands. 30 // account and has issued the graphics commands.
29 virtual void OnCompositingStarted(Compositor* compositor, 31 virtual void OnCompositingStarted(Compositor* compositor,
30 base::TimeTicks start_time) = 0; 32 base::TimeTicks start_time) = 0;
31 33
32 // Called when compositing completes: the present to screen has completed. 34 // Called when compositing completes: the present to screen has completed.
33 virtual void OnCompositingEnded(Compositor* compositor) = 0; 35 virtual void OnCompositingEnded(Compositor* compositor) = 0;
34 36
35 // Called when the compositor lock state changes. 37 // Called when the compositor lock state changes.
36 virtual void OnCompositingLockStateChanged(Compositor* compositor) = 0; 38 virtual void OnCompositingLockStateChanged(Compositor* compositor) = 0;
37 39
38 // Called at the top of the compositor's destructor, to give observers a 40 // Called at the top of the compositor's destructor, to give observers a
39 // chance to remove themselves. 41 // chance to remove themselves.
40 virtual void OnCompositingShuttingDown(Compositor* compositor) = 0; 42 virtual void OnCompositingShuttingDown(Compositor* compositor) = 0;
41 }; 43 };
42 44
43 } // namespace ui 45 } // namespace ui
44 46
45 #endif // UI_COMPOSITOR_COMPOSITOR_OBSERVER_H_ 47 #endif // UI_COMPOSITOR_COMPOSITOR_OBSERVER_H_
OLDNEW
« no previous file with comments | « content/browser/renderer_host/browser_compositor_view_mac.mm ('k') | ui/compositor/test/draw_waiter_for_test.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698