Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Issue 2791603002: Revert of Let ImeAdapterAndroid have the same lifecycle as its Java peer (Closed)

Created:
3 years, 8 months ago by Jinsuk Kim
Modified:
3 years, 8 months ago
CC:
agrieve+watch_chromium.org, chromium-reviews, darin-cc_chromium.org, jam, nona+watch_chromium.org, shuchen+watch_chromium.org, James Su, yusukes+watch_chromium.org, mdjones
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Let ImeAdapterAndroid have the same lifecycle as its Java peer (patchset #13 id:360001 of https://codereview.chromium.org/2752113005/ ) Reason for revert: Relanded but the test failure persists: https://build.chromium.org/p/chromium.android/builders/Marshmallow%2064%20bit%20Tester/builds/10766 Original issue's description: > Let ImeAdapterAndroid have the same lifecycle as its Java peer > > The native ImeAdapterAndroid(IAA) instance is owned by > RenderWidgetHostViewAndroid(RWHVA) while its Java peer > (ImeAdapter) is owned by CVC. This causes their life > cycles to be different. Attach/detach API are used to get them > linked before talking to each other. > > This CL makes this mechanism simpler by having Java ImeAdapter > class create the native together, hence gets their lifetime synced. > The separate attach/detach mechanism is not necessary since > the native is an WebContentObserver, and connected to (or > disconnected from) RWHVA accordingly when notified of RenderView- > Host update callback. Connecting to interstitial page is also > taken care of by observing the appropriate callbacks. > > BUG=662908 > > Review-Url: https://codereview.chromium.org/2752113005 > Cr-Original-Commit-Position: refs/heads/master@{#460028} > Committed: https://chromium.googlesource.com/chromium/src/+/153d2811b3cbcf69cda7ab4817cdc35e7c680dee > Review-Url: https://codereview.chromium.org/2752113005 > Cr-Commit-Position: refs/heads/master@{#461024} > Committed: https://chromium.googlesource.com/chromium/src/+/d01dcc6a7955b96aff2083461319208afc2bc9ca TBR=aelias@chromium.org,boliu@chromium.org,changwan@chromium.org,tedchoc@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=662908 Review-Url: https://codereview.chromium.org/2791603002 Cr-Commit-Position: refs/heads/master@{#461112} Committed: https://chromium.googlesource.com/chromium/src/+/3f7d4c6d1d466214316d4425e46363b2b94caa65

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+618 lines, -639 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchTapEventTest.java View 1 chunk +3 lines, -2 lines 0 comments Download
M content/browser/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/android/browser_jni_registrar.cc View 2 chunks +1 line, -1 line 0 comments Download
M content/browser/android/content_view_core_impl.h View 2 chunks +5 lines, -1 line 0 comments Download
M content/browser/android/content_view_core_impl.cc View 4 chunks +25 lines, -6 lines 0 comments Download
D content/browser/android/ime_adapter_android.h View 1 chunk +0 lines, -127 lines 0 comments Download
D content/browser/android/ime_adapter_android.cc View 1 chunk +0 lines, -424 lines 0 comments Download
A content/browser/renderer_host/ime_adapter_android.h View 1 chunk +116 lines, -0 lines 0 comments Download
A content/browser/renderer_host/ime_adapter_android.cc View 1 chunk +364 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.h View 6 chunks +5 lines, -6 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.cc View 7 chunks +12 lines, -12 lines 0 comments Download
M content/browser/site_per_process_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_contents_view_android.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java View 6 chunks +27 lines, -6 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/SelectionPopupController.java View 3 chunks +5 lines, -1 line 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java View 18 chunks +44 lines, -45 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/PopupZoomerTest.java View 2 chunks +4 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Jinsuk Kim
Created Revert of Let ImeAdapterAndroid have the same lifecycle as its Java peer
3 years, 8 months ago (2017-03-31 14:09:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2791603002/1
3 years, 8 months ago (2017-03-31 14:09:37 UTC) #3
commit-bot: I haz the power
3 years, 8 months ago (2017-03-31 14:11:24 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3f7d4c6d1d466214316d4425e463...

Powered by Google App Engine
This is Rietveld 408576698