DescriptionRevert of Let ImeAdapterAndroid have the same lifecycle as its Java peer (patchset #13 id:360001 of https://codereview.chromium.org/2752113005/ )
Reason for revert:
Relanded but the test failure persists:
https://build.chromium.org/p/chromium.android/builders/Marshmallow%2064%20bit%20Tester/builds/10766
Original issue's description:
> Let ImeAdapterAndroid have the same lifecycle as its Java peer
>
> The native ImeAdapterAndroid(IAA) instance is owned by
> RenderWidgetHostViewAndroid(RWHVA) while its Java peer
> (ImeAdapter) is owned by CVC. This causes their life
> cycles to be different. Attach/detach API are used to get them
> linked before talking to each other.
>
> This CL makes this mechanism simpler by having Java ImeAdapter
> class create the native together, hence gets their lifetime synced.
> The separate attach/detach mechanism is not necessary since
> the native is an WebContentObserver, and connected to (or
> disconnected from) RWHVA accordingly when notified of RenderView-
> Host update callback. Connecting to interstitial page is also
> taken care of by observing the appropriate callbacks.
>
> BUG=662908
>
> Review-Url: https://codereview.chromium.org/2752113005
> Cr-Original-Commit-Position: refs/heads/master@{#460028}
> Committed: https://chromium.googlesource.com/chromium/src/+/153d2811b3cbcf69cda7ab4817cdc35e7c680dee
> Review-Url: https://codereview.chromium.org/2752113005
> Cr-Commit-Position: refs/heads/master@{#461024}
> Committed: https://chromium.googlesource.com/chromium/src/+/d01dcc6a7955b96aff2083461319208afc2bc9ca
TBR=aelias@chromium.org,boliu@chromium.org,changwan@chromium.org,tedchoc@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=662908
Review-Url: https://codereview.chromium.org/2791603002
Cr-Commit-Position: refs/heads/master@{#461112}
Committed: https://chromium.googlesource.com/chromium/src/+/3f7d4c6d1d466214316d4425e46363b2b94caa65
Patch Set 1 #Messages
Total messages: 6 (3 generated)
|