Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(967)

Unified Diff: content/browser/renderer_host/render_widget_host_view_android.h

Issue 2791603002: Revert of Let ImeAdapterAndroid have the same lifecycle as its Java peer (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_view_android.h
diff --git a/content/browser/renderer_host/render_widget_host_view_android.h b/content/browser/renderer_host/render_widget_host_view_android.h
index 08d14dd8b7c7591eac38117c2231e072cf158440..f87762d546fd67173bfe1127f4927d8a7168fd47 100644
--- a/content/browser/renderer_host/render_widget_host_view_android.h
+++ b/content/browser/renderer_host/render_widget_host_view_android.h
@@ -24,6 +24,7 @@
#include "content/browser/accessibility/browser_accessibility_manager.h"
#include "content/browser/android/content_view_core_impl_observer.h"
#include "content/browser/renderer_host/delegated_frame_evictor.h"
+#include "content/browser/renderer_host/ime_adapter_android.h"
#include "content/browser/renderer_host/input/stylus_text_selector.h"
#include "content/browser/renderer_host/render_widget_host_view_base.h"
#include "content/browser/renderer_host/text_input_manager.h"
@@ -50,7 +51,6 @@
namespace content {
class ContentViewCoreImpl;
-class ImeAdapterAndroid;
class OverscrollControllerAndroid;
class RenderWidgetHost;
class RenderWidgetHostImpl;
@@ -224,9 +224,6 @@
void SendMouseEvent(const ui::MotionEventAndroid&, int action_button);
void SendMouseWheelEvent(const blink::WebMouseWheelEvent& event);
void SendGestureEvent(const blink::WebGestureEvent& event);
- void set_ime_adapter(ImeAdapterAndroid* ime_adapter) {
- ime_adapter_android_ = ime_adapter;
- }
void OnStartContentIntent(const GURL& content_url, bool is_main_frame);
@@ -235,6 +232,8 @@
void ResetGestureDetection();
void SetDoubleTapSupportEnabled(bool enabled);
void SetMultiTouchZoomSupportEnabled(bool enabled);
+
+ long GetNativeImeAdapter();
void WasResized();
@@ -270,7 +269,7 @@
void OnTextSelectionChanged(TextInputManager* text_input_manager,
RenderWidgetHostViewBase* updated_view) override;
- ImeAdapterAndroid* ime_adapter_for_testing() { return ime_adapter_android_; }
+ ImeAdapterAndroid* ime_adapter_for_testing() { return &ime_adapter_android_; }
// Exposed for tests.
cc::SurfaceId SurfaceIdForTesting() const override;
@@ -345,7 +344,7 @@
// ContentViewCoreImpl is our interface to the view system.
ContentViewCoreImpl* content_view_core_;
- ImeAdapterAndroid* ime_adapter_android_;
+ ImeAdapterAndroid ime_adapter_android_;
// Body background color of the underlying document.
SkColor cached_background_color_;
« no previous file with comments | « content/browser/renderer_host/ime_adapter_android.cc ('k') | content/browser/renderer_host/render_widget_host_view_android.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698