Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Unified Diff: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

Issue 2791603002: Revert of Let ImeAdapterAndroid have the same lifecycle as its Java peer (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
index 6f3bdb8b681cecabd6beec66235591b7a78d2926..3493dfef590fc0fe5740ccf545029b8efa968368 100644
--- a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
+++ b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
@@ -483,8 +483,8 @@
}
private ImeAdapter createImeAdapter() {
- return new ImeAdapter(mWebContents, new InputMethodManagerWrapper(mContext),
- new ImeAdapter.ImeAdapterDelegate() {
+ return new ImeAdapter(
+ new InputMethodManagerWrapper(mContext), new ImeAdapter.ImeAdapterDelegate() {
@Override
public void onImeEvent() {
mPopupZoomer.hide(true);
@@ -569,9 +569,10 @@
initPopupZoomer(mContext);
mImeAdapter = createImeAdapter();
+ attachImeAdapter();
mSelectionPopupController = new SelectionPopupController(mContext, windowAndroid,
- webContents, viewDelegate.getContainerView(), mRenderCoordinates);
+ webContents, viewDelegate.getContainerView(), mRenderCoordinates, mImeAdapter);
mSelectionPopupController.setCallback(ActionModeCallbackHelper.EMPTY_CALLBACK);
mSelectionPopupController.setContainerView(getContainerView());
@@ -1781,14 +1782,16 @@
}
@CalledByNative
- private void updateImeAdapter(int textInputType, int textInputFlags, int textInputMode,
- String text, int selectionStart, int selectionEnd, int compositionStart,
- int compositionEnd, boolean showImeIfNeeded, boolean replyToRequest) {
+ private void updateImeAdapter(long nativeImeAdapterAndroid, int textInputType,
+ int textInputFlags, int textInputMode, String text, int selectionStart,
+ int selectionEnd, int compositionStart, int compositionEnd, boolean showImeIfNeeded,
+ boolean replyToRequest) {
try {
TraceEvent.begin("ContentViewCore.updateImeAdapter");
boolean focusedNodeEditable = (textInputType != TextInputType.NONE);
boolean focusedNodeIsPassword = (textInputType == TextInputType.PASSWORD);
+ mImeAdapter.attach(nativeImeAdapterAndroid);
mImeAdapter.updateState(textInputType, textInputFlags, textInputMode, showImeIfNeeded,
text, selectionStart, selectionEnd, compositionStart, compositionEnd,
replyToRequest);
@@ -1807,6 +1810,11 @@
}
}
+ @CalledByNative
+ private void forceUpdateImeAdapter(long nativeImeAdapterAndroid) {
+ mImeAdapter.attach(nativeImeAdapterAndroid);
+ }
+
/**
* Called (from native) when the <select> popup needs to be shown.
* @param anchorView View anchored for popup.
@@ -1917,8 +1925,18 @@
@SuppressWarnings("unused")
@CalledByNative
private void onRenderProcessChange() {
+ attachImeAdapter();
// Immediately sync closed caption settings to the new render process.
mSystemCaptioningBridge.syncToListener(this);
+ }
+
+ /**
+ * Attaches the native ImeAdapter object to the java ImeAdapter to allow communication via JNI.
+ */
+ public void attachImeAdapter() {
+ if (mImeAdapter != null && mNativeContentViewCore != 0) {
+ mImeAdapter.attach(nativeGetNativeImeAdapter(mNativeContentViewCore));
+ }
}
/**
@@ -2645,6 +2663,9 @@
private native void nativeSelectPopupMenuItems(long nativeContentViewCoreImpl,
long nativeSelectPopupSourceFrame, int[] indices);
+
+ private native long nativeGetNativeImeAdapter(long nativeContentViewCoreImpl);
+
private native int nativeGetCurrentRenderProcessId(long nativeContentViewCoreImpl);
private native void nativeSetAllowJavascriptInterfacesInspection(

Powered by Google App Engine
This is Rietveld 408576698