Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2791403004:
Don't use --gdb-index for Gold and LLVM linker (Closed)
|
Created:
3 years, 8 months ago by kjellander_chromium Modified:
3 years, 8 months ago Reviewers:
Nico CC:
chromium-reviews Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionDon't use --gdb-index for Gold and LLVM linker
It appears --gdb-index is not supported for Gold or the LLVM linker.
This was discovered after https://codereview.chromium.org/2786603003
and affected builds configurations like Linux ARM64 Debug.
BUG=708104
Review-Url: https://codereview.chromium.org/2791403004
Cr-Commit-Position: refs/heads/master@{#461781}
Committed: https://chromium.googlesource.com/chromium/src/+/1c4b5eb17214fa0aedea5193628c74312f71a2d2
Patch Set 1 #
Total comments: 5
Patch Set 2 : Updating condition #Messages
Total messages: 25 (16 generated)
Description was changed from ========== Disable --gdb-index for Linux ARM64 Debug builds. After https://codereview.chromium.org/2786603003 Linux ARM64 Debug compilation fails: $ gn gen out/linux-arm64-debug --args='is_debug=true target_cpu="arm64" use_goma=true' $ ninja -C out/linux-arm64-debug/ base_unittests ... /usr/bin/aarch64-linux-gnu-ld: unrecognized option '--gdb-index' /usr/bin/aarch64-linux-gnu-ld: use the --help option for usage information clang: error: linker command failed with exit code 1 (use -v to see invocation) BUG=708104 ========== to ========== Disable --gdb-index for Linux ARM64 Debug builds. After https://codereview.chromium.org/2786603003 Linux ARM64 Debug compilation fails: $ gn gen out/linux-arm64-debug --args='is_debug=true target_cpu="arm64" use_goma=true' $ ninja -C out/linux-arm64-debug/ base_unittests ... /usr/bin/aarch64-linux-gnu-ld: unrecognized option '--gdb-index' /usr/bin/aarch64-linux-gnu-ld: use the --help option for usage information clang: error: linker command failed with exit code 1 (use -v to see invocation) BUG=708104 ==========
kjellander@chromium.org changed reviewers: + thakis@chromium.org
The CQ bit was checked by kjellander@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2791403004/diff/1/build/config/compiler/BUILD.gn File build/config/compiler/BUILD.gn (right): https://codereview.chromium.org/2791403004/diff/1/build/config/compiler/BUILD... build/config/compiler/BUILD.gn:1660: # TODO(thakis): Figure out how to make this go for Linux ARM64 Debug, Are you OK with me assigning a TODO for you? I personally don't know how to fix this so putting my name in there wouldn't make any sense.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/2791403004/diff/1/build/config/compiler/BUILD.gn File build/config/compiler/BUILD.gn (right): https://codereview.chromium.org/2791403004/diff/1/build/config/compiler/BUILD... build/config/compiler/BUILD.gn:1664: !(is_linux && target_cpu == "arm64" && is_debug) && This is because we don't use gold in this config, yeah? Should this be && !(use_gold || use_lld)?
https://codereview.chromium.org/2791403004/diff/1/build/config/compiler/BUILD.gn File build/config/compiler/BUILD.gn (right): https://codereview.chromium.org/2791403004/diff/1/build/config/compiler/BUILD... build/config/compiler/BUILD.gn:1664: !(is_linux && target_cpu == "arm64" && is_debug) && On 2017/04/04 13:47:29, Nico (afk until Tue Apr 4) wrote: > This is because we don't use gold in this config, yeah? Should this be && > !(use_gold || use_lld)? Something along those lines sounds like the proper fix (I guess I'll remove the TODO in that case). But both those variables are false for Linux ARM64 Debug, so that will trigger the same error. Any other suggestion?
https://codereview.chromium.org/2791403004/diff/1/build/config/compiler/BUILD.gn File build/config/compiler/BUILD.gn (right): https://codereview.chromium.org/2791403004/diff/1/build/config/compiler/BUILD... build/config/compiler/BUILD.gn:1664: !(is_linux && target_cpu == "arm64" && is_debug) && On 2017/04/04 14:35:35, kjellander_chromium wrote: > On 2017/04/04 13:47:29, Nico (afk until Tue Apr 4) wrote: > > This is because we don't use gold in this config, yeah? Should this be && > > !(use_gold || use_lld)? > > Something along those lines sounds like the proper fix (I guess I'll remove the > TODO in that case). > But both those variables are false for Linux ARM64 Debug, so that will trigger > the same error. Any other suggestion? Oh, I guess I mean (use_gold || use_lld) without the ! (sorry, bools are hard).
https://codereview.chromium.org/2791403004/diff/1/build/config/compiler/BUILD.gn File build/config/compiler/BUILD.gn (right): https://codereview.chromium.org/2791403004/diff/1/build/config/compiler/BUILD... build/config/compiler/BUILD.gn:1664: !(is_linux && target_cpu == "arm64" && is_debug) && On 2017/04/04 14:50:06, Nico (afk until Tue Apr 4) wrote: > On 2017/04/04 14:35:35, kjellander_chromium wrote: > > On 2017/04/04 13:47:29, Nico (afk until Tue Apr 4) wrote: > > > This is because we don't use gold in this config, yeah? Should this be && > > > !(use_gold || use_lld)? > > > > Something along those lines sounds like the proper fix (I guess I'll remove > the > > TODO in that case). > > But both those variables are false for Linux ARM64 Debug, so that will trigger > > the same error. Any other suggestion? > > Oh, I guess I mean (use_gold || use_lld) without the ! (sorry, bools are hard). :) That works much better.
The CQ bit was checked by kjellander@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Lgtm, thanks. Maybe update the cl description before landing.
Description was changed from ========== Disable --gdb-index for Linux ARM64 Debug builds. After https://codereview.chromium.org/2786603003 Linux ARM64 Debug compilation fails: $ gn gen out/linux-arm64-debug --args='is_debug=true target_cpu="arm64" use_goma=true' $ ninja -C out/linux-arm64-debug/ base_unittests ... /usr/bin/aarch64-linux-gnu-ld: unrecognized option '--gdb-index' /usr/bin/aarch64-linux-gnu-ld: use the --help option for usage information clang: error: linker command failed with exit code 1 (use -v to see invocation) BUG=708104 ========== to ========== Disable --gdb-index for Gold and LLVM linkers It appears --gdb-index is not supported for Gold or the LLVM linker. This was discovered after https://codereview.chromium.org/2786603003 and affected builds configurations like Linux ARM64 Debug. BUG=708104 ==========
Description was changed from ========== Disable --gdb-index for Gold and LLVM linkers It appears --gdb-index is not supported for Gold or the LLVM linker. This was discovered after https://codereview.chromium.org/2786603003 and affected builds configurations like Linux ARM64 Debug. BUG=708104 ========== to ========== Disable --gdb-index for Gold and LLVM linker It appears --gdb-index is not supported for Gold or the LLVM linker. This was discovered after https://codereview.chromium.org/2786603003 and affected builds configurations like Linux ARM64 Debug. BUG=708104 ==========
Description was changed from ========== Disable --gdb-index for Gold and LLVM linker It appears --gdb-index is not supported for Gold or the LLVM linker. This was discovered after https://codereview.chromium.org/2786603003 and affected builds configurations like Linux ARM64 Debug. BUG=708104 ========== to ========== Don't use --gdb-index for Gold and LLVM linker It appears --gdb-index is not supported for Gold or the LLVM linker. This was discovered after https://codereview.chromium.org/2786603003 and affected builds configurations like Linux ARM64 Debug. BUG=708104 ==========
On 2017/04/04 16:33:16, Nico (afk until Tue Apr 4) wrote: > Lgtm, thanks. Maybe update the cl description before landing. Thanks, updated.
The CQ bit was checked by kjellander@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491329960120490,
"parent_rev": "c69cbb716c31aa6fc635f52d314781d35222b73f", "commit_rev":
"1c4b5eb17214fa0aedea5193628c74312f71a2d2"}
Message was sent while issue was closed.
Description was changed from ========== Don't use --gdb-index for Gold and LLVM linker It appears --gdb-index is not supported for Gold or the LLVM linker. This was discovered after https://codereview.chromium.org/2786603003 and affected builds configurations like Linux ARM64 Debug. BUG=708104 ========== to ========== Don't use --gdb-index for Gold and LLVM linker It appears --gdb-index is not supported for Gold or the LLVM linker. This was discovered after https://codereview.chromium.org/2786603003 and affected builds configurations like Linux ARM64 Debug. BUG=708104 Review-Url: https://codereview.chromium.org/2791403004 Cr-Commit-Position: refs/heads/master@{#461781} Committed: https://chromium.googlesource.com/chromium/src/+/1c4b5eb17214fa0aedea5193628c... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/1c4b5eb17214fa0aedea5193628c... |
