(Really) disable gdb-index for LTO.

(Really) disable gdb-index for LTO.

This is a follow up to https://codereview.chromium.org/2782483002,
where only official LTO builds had got gdb-index disabled.

BUG=660216
Review-Url: https://codereview.chromium.org/2786603003
Cr-Commit-Position: refs/heads/master@{#460421}
Committed: https://chromium.googlesource.com/chromium/src/+/95e4983f85e5afb97b37df59b5666b2f3d2949a1

[krasin1, 2017-03-29 15:22:13]

krasin@chromium.org changed reviewers:
+ scottmg@chromium.org

[Nico, 2017-03-29 15:31:55]

thakis@chromium.org changed reviewers:
+ thakis@chromium.org

[Nico, 2017-03-29 15:31:55]

Lgtm. Is there a bug to make this work with LTO? Why doesn't it just work?

[Nico, 2017-03-29 15:32:32]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2017-03-29 15:33:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[krasin1, 2017-03-29 15:35:28]

On 2017/03/29 15:31:55, Nico wrote:
> Lgtm. Is there a bug to make this work with LTO?
No idea, really. Is there a bug to enable gdb-index in all configurations? As
gdb-index is a new development (at least, for Chrome), and LTO has been for a
while, I would just reuse the gdb-index bug.

> Why doesn't it just work?
No idea, again. I have never used gdb-index before, and don't have any intuition
here. Asking Peter (pcc@) might help.

[Nico, 2017-03-29 15:54:02]

On 2017/03/29 15:35:28, krasin1 wrote:
> On 2017/03/29 15:31:55, Nico wrote:
> > Lgtm. Is there a bug to make this work with LTO?
> No idea, really. Is there a bug to enable gdb-index in all configurations? As
> gdb-index is a new development (at least, for Chrome),

It's not that new. We had it on by default 2 years ago, but had to disable it
cause some tooling didn't work well with it (notably, gdb dislikes fission +
gdb-index). So it was behind a flag for a while. I tried turning it on by
default, but it looks like tools are still sad.

> and LTO has been for a
> while, I would just reuse the gdb-index bug.
> 
> > Why doesn't it just work?
> No idea, again. I have never used gdb-index before, and don't have any
intuition
> here. Asking Peter (pcc@) might help.

[krasin1, 2017-03-29 16:07:25]

Thank you for adding more context. Interesting.
I will file a bug; not promising that I will work on it, but at least I will try
to understand what's wrong with it.

[krasin1, 2017-03-29 16:12:52]

On 2017/03/29 16:07:25, krasin1 wrote:
> Thank you for adding more context. Interesting.
> I will file a bug; not promising that I will work on it, but at least I will
try
> to understand what's wrong with it.

Filed https://crbug.com/706429

[commit-bot: I haz the power, 2017-03-29 16:37:44]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1490801552962920, "parent_rev":
"a3fa213abee042db7dd7523582f982c2dd72b056", "commit_rev":
"95e4983f85e5afb97b37df59b5666b2f3d2949a1"}

[commit-bot: I haz the power, 2017-03-29 16:38:29]

Description was changed from

==========
(Really) disable gdb-index for LTO.

This is a follow up to https://codereview.chromium.org/2782483002,
where only official LTO builds had got gdb-index disabled.

BUG=660216
==========

to

==========
(Really) disable gdb-index for LTO.

This is a follow up to https://codereview.chromium.org/2782483002,
where only official LTO builds had got gdb-index disabled.

BUG=660216

Review-Url: https://codereview.chromium.org/2786603003
Cr-Commit-Position: refs/heads/master@{#460421}
Committed:
https://chromium.googlesource.com/chromium/src/+/95e4983f85e5afb97b37df59b566...
==========

[commit-bot: I haz the power, 2017-03-29 16:38:30]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/95e4983f85e5afb97b37df59b566...

[kjellander_chromium, 2017-04-04 08:30:02]

On 2017/03/29 16:38:30, commit-bot: I haz the power wrote:
> Committed patchset #1 (id:1) as
>
https://chromium.googlesource.com/chromium/src/+/95e4983f85e5afb97b37df59b566...

I suspect this breaks Linux ARM64 Debug builds (uncovered by Chromium bots).
I filed https://bugs.chromium.org/p/chromium/issues/detail?id=708104 for that.

[krasin1, 2017-04-04 15:22:17]

On 2017/04/04 08:30:02, kjellander_chromium wrote:
> On 2017/03/29 16:38:30, commit-bot: I haz the power wrote:
> > Committed patchset #1 (id:1) as
> >
>
https://chromium.googlesource.com/chromium/src/+/95e4983f85e5afb97b37df59b566...
> 
> I suspect this breaks Linux ARM64 Debug builds (uncovered by Chromium bots).
> I filed https://bugs.chromium.org/p/chromium/issues/detail?id=708104 for that.

Since this CL disables gdb-index in some configurations, not enables it, are you
sure it's the right CL to blame? Did you mean
https://codereview.chromium.org/2770933009/ where it got enabled?