Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Unified Diff: build/config/compiler/BUILD.gn

Issue 2791403004: Don't use --gdb-index for Gold and LLVM linker (Closed)
Patch Set: Updating condition Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/compiler/BUILD.gn
diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn
index 08e9a9ef988737dcc6eaedee39e7b0021f20df0b..5cc1ca1842565bf76f642588c689f47f8125ea1b 100644
--- a/build/config/compiler/BUILD.gn
+++ b/build/config/compiler/BUILD.gn
@@ -1658,7 +1658,8 @@ config("symbols") {
# "third_party/binutils/Linux_x64/Release/bin/ld.gold: warning:
# /tmp/lto-llvm-0b5201.o: corrupt debug info in .debug_info"
if (!is_mac && !is_ios && !is_nacl && target_cpu != "x86" &&
- !allow_posix_link_time_opt && !is_official_build) {
+ (use_gold || use_lld) && !allow_posix_link_time_opt &&
+ !is_official_build) {
ldflags += [ "-Wl,--gdb-index" ]
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698