Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2427)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/suggestions/MostVisitedSites.java

Issue 2790463003: ntp_tiles: Cleanup enum names (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/suggestions/MostVisitedSites.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/suggestions/MostVisitedSites.java b/chrome/android/java/src/org/chromium/chrome/browser/suggestions/MostVisitedSites.java
index 0e392dd048fa7ed5e5371e96c717c5acd4bf321b..94276f6e299ad4233b0260038eed907533262848 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/suggestions/MostVisitedSites.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/suggestions/MostVisitedSites.java
@@ -5,8 +5,8 @@
package org.chromium.chrome.browser.suggestions;
import org.chromium.base.annotations.CalledByNative;
-import org.chromium.chrome.browser.ntp.MostVisitedTileType;
import org.chromium.chrome.browser.ntp.NTPTileSource;
+import org.chromium.chrome.browser.ntp.NTPTileType;
/**
* Methods to provide most recent urls, titles and thumbnails.
@@ -68,7 +68,7 @@ interface MostVisitedSites {
/**
* Records metrics about an impression, including the sources (local, server, ...) and visual
* types of the tiles that are shown.
- * @param tileTypes An array of values from MostVisitedTileType indicating the type of each
+ * @param tileTypes An array of values from NTPTileType indicating the type of each
Michael van Ouwerkerk 2017/03/31 09:01:15 {@link NTPTileType}
Marc Treib 2017/04/03 13:23:09 Done.
* tile that's currently showing.
* @param sources An array of values from NTPTileSource indicating the source of each tile
* that's currently showing.
@@ -79,10 +79,9 @@ interface MostVisitedSites {
/**
* Records the opening of a Most Visited Item.
* @param index The index of the item that was opened.
- * @param type The visual type of the item as defined in {@code MostVisitedTileType}.
+ * @param type The visual type of the item as defined in {@code NTPTileType}.
Michael van Ouwerkerk 2017/03/31 09:01:15 {@link NTPTileType}
Marc Treib 2017/04/03 13:23:09 Done.
* @param source The {@code NTPTileSource} that generated this item.
*/
- void recordOpenedMostVisitedItem(int index,
- @MostVisitedTileType.MostVisitedTileTypeEnum int type,
+ void recordOpenedMostVisitedItem(int index, @NTPTileType.NTPTileTypeEnum int type,
@NTPTileSource.NTPTileSourceEnum int source);
}

Powered by Google App Engine
This is Rietveld 408576698