Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2790353002:
[MD Bookmarks] Auto expand folders on drag hover. (Closed)
Description[MD Bookmarks] Auto expand folders on drag hover.
BUG=692843
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2790353002
Cr-Commit-Position: refs/heads/master@{#463182}
Committed: https://chromium.googlesource.com/chromium/src/+/c7e2f44b15e8b8e23ce1d96cadf0174f707aa74a
Patch Set 1 : #
Total comments: 8
Patch Set 2 : address comments #
Depends on Patchset: Dependent Patchsets: Messages
Total messages: 25 (19 generated)
Description was changed from ========== [MD Bookmarks] Auto expand folders on drag hover. BUG=692843 ========== to ========== [MD Bookmarks] Auto expand folders on drag hover. BUG=692843 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Patchset #2 (id:20001) has been deleted
Patchset #1 (id:1) has been deleted
The CQ bit was checked by calamity@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
Patchset #1 (id:40001) has been deleted
calamity@chromium.org changed reviewers: + tsergeant@chromium.org
Neat! https://codereview.chromium.org/2790353002/diff/60001/chrome/browser/resource... File chrome/browser/resources/md_bookmarks/dnd_manager.js (right): https://codereview.chromium.org/2790353002/diff/60001/chrome/browser/resource... chrome/browser/resources/md_bookmarks/dnd_manager.js:138: * @param {BookmarkElement} overElement Nit: Annotate as ?, since it is nullable https://codereview.chromium.org/2790353002/diff/60001/chrome/browser/resource... chrome/browser/resources/md_bookmarks/dnd_manager.js:142: var itemId = overElement.itemId; overelement can be null (which is important, I guess, since it allows you to reset the timeout when dragging off the sidebar), so this line causes a TypeError. https://codereview.chromium.org/2790353002/diff/60001/chrome/test/data/webui/... File chrome/test/data/webui/md_bookmarks/dnd_manager_test.js (right): https://codereview.chromium.org/2790353002/diff/60001/chrome/test/data/webui/... chrome/test/data/webui/md_bookmarks/dnd_manager_test.js:403: Nit: extra \n https://codereview.chromium.org/2790353002/diff/60001/chrome/test/data/webui/... chrome/test/data/webui/md_bookmarks/dnd_manager_test.js:423: assertEquals(0, autoExpander.lastTimestamp_); Add a case for when overelement is null
Patchset #3 (id:100001) has been deleted
Patchset #2 (id:80001) has been deleted
Patchset #2 (id:120001) has been deleted
The CQ bit was checked by calamity@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/2790353002/diff/60001/chrome/browser/resource... File chrome/browser/resources/md_bookmarks/dnd_manager.js (right): https://codereview.chromium.org/2790353002/diff/60001/chrome/browser/resource... chrome/browser/resources/md_bookmarks/dnd_manager.js:138: * @param {BookmarkElement} overElement On 2017/04/05 07:49:36, tsergeant wrote: > Nit: Annotate as ?, since it is nullable Done. https://codereview.chromium.org/2790353002/diff/60001/chrome/browser/resource... chrome/browser/resources/md_bookmarks/dnd_manager.js:142: var itemId = overElement.itemId; On 2017/04/05 07:49:36, tsergeant wrote: > overelement can be null (which is important, I guess, since it allows you to > reset the timeout when dragging off the sidebar), so this line causes a > TypeError. Done. https://codereview.chromium.org/2790353002/diff/60001/chrome/test/data/webui/... File chrome/test/data/webui/md_bookmarks/dnd_manager_test.js (right): https://codereview.chromium.org/2790353002/diff/60001/chrome/test/data/webui/... chrome/test/data/webui/md_bookmarks/dnd_manager_test.js:403: On 2017/04/05 07:49:36, tsergeant wrote: > Nit: extra \n Done. https://codereview.chromium.org/2790353002/diff/60001/chrome/test/data/webui/... chrome/test/data/webui/md_bookmarks/dnd_manager_test.js:423: assertEquals(0, autoExpander.lastTimestamp_); On 2017/04/05 07:49:36, tsergeant wrote: > Add a case for when overelement is null Done.
lgtm
The CQ bit was checked by calamity@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 140001, "attempt_start_ts": 1491803641943340,
"parent_rev": "0a53e4a6705344328237af20bc6276be1805fad7", "commit_rev":
"c7e2f44b15e8b8e23ce1d96cadf0174f707aa74a"}
Message was sent while issue was closed.
Description was changed from ========== [MD Bookmarks] Auto expand folders on drag hover. BUG=692843 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== [MD Bookmarks] Auto expand folders on drag hover. BUG=692843 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2790353002 Cr-Commit-Position: refs/heads/master@{#463182} Committed: https://chromium.googlesource.com/chromium/src/+/c7e2f44b15e8b8e23ce1d96cadf0... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:140001) as https://chromium.googlesource.com/chromium/src/+/c7e2f44b15e8b8e23ce1d96cadf0... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
