[MD Bookmarks] Fix sidebar issues.

[MD Bookmarks] Fix sidebar issues.

This CL fixes the search box not accounting for the sidebar on a fresh
profile, makes the search box update every frame of a drag, and adds a
test for storing the sidebar width in local storage.

BUG=708404
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2804543002
Cr-Commit-Position: refs/heads/master@{#463543}
Committed: https://chromium.googlesource.com/chromium/src/+/5019f85de11bc85d3d8ab32cf4aca11fb6f1381d

[calamity, 2017-04-05 06:59:40]

Description was changed from

==========
[MD Bookmarks] Fix sidebar issues.

This CL fixes the search box not accounting for the sidebar on a fresh
profile, makes the search box update every frame of a drag, and adds a
test for storing the sidebar width in local storage.

BUG=708404
==========

to

==========
[MD Bookmarks] Fix sidebar issues.

This CL fixes the search box not accounting for the sidebar on a fresh
profile, makes the search box update every frame of a drag, and adds a
test for storing the sidebar width in local storage.

BUG=708404
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[calamity, 2017-04-05 07:13:48]

Patchset #2 (id:20001) has been deleted

[calamity, 2017-04-05 07:14:11]

calamity@chromium.org changed reviewers:
+ tsergeant@chromium.org

[tsergeant, 2017-04-05 08:07:55]

lgtm

https://codereview.chromium.org/2804543002/diff/1/chrome/browser/resources/md...
File chrome/browser/resources/md_bookmarks/constants.js (right):

https://codereview.chromium.org/2804543002/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_bookmarks/constants.js:22: var
LOCAL_STORAGE_TREE_WIDTH_KEY = 'treeWidth';
Nit: Should we make these two keys consistent? I'd be happy to rename the one
above to match this new one.

[calamity, 2017-04-10 03:00:21]

The CQ bit was checked by calamity@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-10 03:00:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-10 04:19:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-10 04:19:40]

Dry run: This issue passed the CQ dry run.

[calamity, 2017-04-10 04:26:58]

The CQ bit was checked by calamity@chromium.org

[calamity, 2017-04-10 04:26:58]

The patchset sent to the CQ was uploaded after l-g-t-m from
tsergeant@chromium.org
Link to the patchset: https://codereview.chromium.org/2804543002/#ps40001
(title: " ")

[calamity, 2017-04-10 04:27:11]

https://codereview.chromium.org/2804543002/diff/1/chrome/browser/resources/md...
File chrome/browser/resources/md_bookmarks/constants.js (right):

https://codereview.chromium.org/2804543002/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_bookmarks/constants.js:22: var
LOCAL_STORAGE_TREE_WIDTH_KEY = 'treeWidth';
On 2017/04/05 08:07:55, tsergeant wrote:
> Nit: Should we make these two keys consistent? I'd be happy to rename the one
> above to match this new one.

Done.

[commit-bot: I haz the power, 2017-04-10 04:27:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-10 04:33:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-10 04:33:54]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[calamity, 2017-04-10 05:53:33]

calamity@chromium.org changed reviewers:
+ dbeam@chromium.org

[calamity, 2017-04-10 05:53:33]

+dbeam for splitter.js OWNERS.

[Dan Beam, 2017-04-11 01:27:02]

lgtm

https://codereview.chromium.org/2804543002/diff/40001/chrome/browser/resource...
File chrome/browser/resources/md_bookmarks/app.js (right):

https://codereview.chromium.org/2804543002/diff/40001/chrome/browser/resource...
chrome/browser/resources/md_bookmarks/app.js:99: }.bind(this));
nit: could also be

splitter.addEventListener('dragmove', this.updateSidebarWidth_.bind(this));

if you don't care about omitting the param

[calamity, 2017-04-11 03:15:53]

The CQ bit was checked by calamity@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-11 03:16:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[calamity, 2017-04-11 03:19:41]

The CQ bit was checked by calamity@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-11 03:19:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[calamity, 2017-04-11 03:22:37]

The CQ bit was checked by calamity@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-11 03:22:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[calamity, 2017-04-11 03:31:39]

https://codereview.chromium.org/2804543002/diff/40001/chrome/browser/resource...
File chrome/browser/resources/md_bookmarks/app.js (right):

https://codereview.chromium.org/2804543002/diff/40001/chrome/browser/resource...
chrome/browser/resources/md_bookmarks/app.js:99: }.bind(this));
On 2017/04/11 01:27:02, Dan Beam wrote:
> nit: could also be
> 
> splitter.addEventListener('dragmove', this.updateSidebarWidth_.bind(this));
> 
> if you don't care about omitting the param

Done.

[commit-bot: I haz the power, 2017-04-11 04:19:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-11 04:19:50]

Dry run: This issue passed the CQ dry run.

[calamity, 2017-04-11 05:12:38]

The CQ bit was checked by calamity@chromium.org

[calamity, 2017-04-11 05:12:39]

The patchset sent to the CQ was uploaded after l-g-t-m from
tsergeant@chromium.org, dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/2804543002/#ps60001
(title: "dbeam review")

[commit-bot: I haz the power, 2017-04-11 05:13:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-11 05:20:01]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1491887558631290,
"parent_rev": "1dcdbf04f8b291c23aa0c6b05aaca1b0fb31b9be", "commit_rev":
"5019f85de11bc85d3d8ab32cf4aca11fb6f1381d"}

[commit-bot: I haz the power, 2017-04-11 05:21:21]

Description was changed from

==========
[MD Bookmarks] Fix sidebar issues.

This CL fixes the search box not accounting for the sidebar on a fresh
profile, makes the search box update every frame of a drag, and adds a
test for storing the sidebar width in local storage.

BUG=708404
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD Bookmarks] Fix sidebar issues.

This CL fixes the search box not accounting for the sidebar on a fresh
profile, makes the search box update every frame of a drag, and adds a
test for storing the sidebar width in local storage.

BUG=708404
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2804543002
Cr-Commit-Position: refs/heads/master@{#463543}
Committed:
https://chromium.googlesource.com/chromium/src/+/5019f85de11bc85d3d8ab32cf4ac...
==========

[commit-bot: I haz the power, 2017-04-11 05:21:23]

Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/5019f85de11bc85d3d8ab32cf4ac...