[MD Bookmarks] Change selection items from Map to Set.

[MD Bookmarks] Change selection items from Map to Set.

This CL changes the type of the selection items to a Set to accurately
reflect the data being stored.

BUG=697706
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2774233006
Cr-Commit-Position: refs/heads/master@{#461655}
Committed: https://chromium.googlesource.com/chromium/src/+/65d1e47c314fee42363b652ddbccf0dbea9a73c7

[calamity, 2017-03-29 02:48:39]

Description was changed from

==========
[MD Bookmarks] Change selection items from Map to Set.

This CL changes the type of the selection items to a Set to accurately
reflect the data being stored.

BUG=697706
==========

to

==========
[MD Bookmarks] Change selection items from Map to Set.

This CL changes the type of the selection items to a Set to accurately
reflect the data being stored.

BUG=697706
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[calamity, 2017-03-30 03:47:39]

Patchset #1 (id:1) has been deleted

[calamity, 2017-03-30 03:52:46]

calamity@chromium.org changed reviewers:
+ tsergeant@chromium.org

[calamity, 2017-03-30 03:52:47]

I think the main disadvantage here is that we can't easily JSON.stringify()
Sets. Maybe it's better to define a SetMap type? Dunno, WDYT?

[tsergeant, 2017-03-30 23:00:19]

lgtm. I don't think the conversion to/from JSON is too bad, considering the
improvement in the rest of the code.

[calamity, 2017-04-03 02:39:16]

The CQ bit was checked by calamity@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-03 02:39:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-03 02:41:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-03 02:41:28]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[calamity, 2017-04-04 02:58:49]

The CQ bit was checked by calamity@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-04 02:59:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-04 03:02:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-04 03:02:59]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[calamity, 2017-04-04 05:38:54]

The CQ bit was checked by calamity@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-04 05:39:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-04 05:41:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-04 05:41:44]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[calamity, 2017-04-04 06:30:07]

The CQ bit was checked by calamity@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-04 06:30:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-04 07:23:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-04 07:23:32]

Dry run: This issue passed the CQ dry run.

[calamity, 2017-04-04 07:47:20]

The CQ bit was checked by calamity@chromium.org

[calamity, 2017-04-04 07:47:21]

The patchset sent to the CQ was uploaded after l-g-t-m from
tsergeant@chromium.org
Link to the patchset: https://codereview.chromium.org/2774233006/#ps60001
(title: "rebase")

[commit-bot: I haz the power, 2017-04-04 07:47:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-04 07:53:04]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1491292040490590,
"parent_rev": "26e7e7bd8879b099de4183bc53859af062e41fcc", "commit_rev":
"65d1e47c314fee42363b652ddbccf0dbea9a73c7"}

[commit-bot: I haz the power, 2017-04-04 07:53:51]

Description was changed from

==========
[MD Bookmarks] Change selection items from Map to Set.

This CL changes the type of the selection items to a Set to accurately
reflect the data being stored.

BUG=697706
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD Bookmarks] Change selection items from Map to Set.

This CL changes the type of the selection items to a Set to accurately
reflect the data being stored.

BUG=697706
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2774233006
Cr-Commit-Position: refs/heads/master@{#461655}
Committed:
https://chromium.googlesource.com/chromium/src/+/65d1e47c314fee42363b652ddbcc...
==========

[commit-bot: I haz the power, 2017-04-04 07:53:52]

Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/65d1e47c314fee42363b652ddbcc...