Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 279023002: Add GN function get_label_info (Closed)

Created:
6 years, 7 months ago by brettw
Modified:
6 years, 7 months ago
Reviewers:
cjhopman
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

Add GN function get_label_info This function retrieves information about a label like the name, directory, etc. R=cjhopman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270130

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : merge #

Total comments: 1

Patch Set 4 : review comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+305 lines, -25 lines) Patch
M tools/gn/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
M tools/gn/builder_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/filesystem_utils.h View 1 2 3 1 chunk +10 lines, -0 lines 0 comments Download
M tools/gn/filesystem_utils.cc View 1 2 3 3 chunks +25 lines, -0 lines 0 comments Download
M tools/gn/filesystem_utils_unittest.cc View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
A tools/gn/function_get_label_info.cc View 1 chunk +153 lines, -0 lines 0 comments Download
A tools/gn/function_get_label_info_unittest.cc View 1 1 chunk +92 lines, -0 lines 0 comments Download
M tools/gn/functions.h View 1 chunk +8 lines, -0 lines 0 comments Download
M tools/gn/functions.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M tools/gn/gn.gyp View 1 2 chunks +2 lines, -0 lines 0 comments Download
M tools/gn/loader.cc View 1 chunk +0 lines, -14 lines 0 comments Download
M tools/gn/scope_per_file_provider_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/settings.h View 1 2 3 1 chunk +6 lines, -4 lines 0 comments Download
M tools/gn/settings.cc View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
brettw
6 years, 7 months ago (2014-05-12 16:24:31 UTC) #1
cjhopman
https://codereview.chromium.org/279023002/diff/60001/tools/gn/filesystem_utils.h File tools/gn/filesystem_utils.h (right): https://codereview.chromium.org/279023002/diff/60001/tools/gn/filesystem_utils.h#newcode173 tools/gn/filesystem_utils.h:173: std::string GetOutputSubdirName(const Label& toolchain_label, bool is_default); It looks like ...
6 years, 7 months ago (2014-05-12 16:50:05 UTC) #2
brettw
Fixed, new snap up.
6 years, 7 months ago (2014-05-12 21:15:30 UTC) #3
cjhopman
lgtm
6 years, 7 months ago (2014-05-12 21:18:35 UTC) #4
brettw
6 years, 7 months ago (2014-05-13 16:58:20 UTC) #5
Message was sent while issue was closed. 
Committed patchset #4 manually as r270130 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698