Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(546)

Unified Diff: tools/gn/filesystem_utils_unittest.cc

Issue 279023002: Add GN function get_label_info (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: review comment Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/filesystem_utils.cc ('k') | tools/gn/function_get_label_info.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/filesystem_utils_unittest.cc
diff --git a/tools/gn/filesystem_utils_unittest.cc b/tools/gn/filesystem_utils_unittest.cc
index ec1a53e7633d04d11d67f9c662a403af830dadac..906d672bdd2db245de6e21eca04be4b3e9eaa0fa 100644
--- a/tools/gn/filesystem_utils_unittest.cc
+++ b/tools/gn/filesystem_utils_unittest.cc
@@ -336,7 +336,7 @@ TEST(FilesystemUtils, GetToolchainDirs) {
EXPECT_EQ("//out/Debug/gen/",
GetToolchainGenDir(&default_settings).value());
- Settings other_settings(&build_settings, "two");
+ Settings other_settings(&build_settings, "two/");
EXPECT_EQ("//out/Debug/two/",
GetToolchainOutputDir(&other_settings).value());
EXPECT_EQ("//out/Debug/two/gen/",
@@ -357,7 +357,7 @@ TEST(FilesystemUtils, GetOutDirForSourceDir) {
SourceDir("//foo/bar/")).value());
// Secondary toolchain.
- Settings other_settings(&build_settings, "two");
+ Settings other_settings(&build_settings, "two/");
EXPECT_EQ("//out/Debug/two/obj/",
GetOutputDirForSourceDir(&other_settings, SourceDir("//")).value());
EXPECT_EQ("//out/Debug/two/obj/foo/bar/",
@@ -378,7 +378,7 @@ TEST(FilesystemUtils, GetGenDirForSourceDir) {
SourceDir("//foo/bar/")).value());
// Secondary toolchain.
- Settings other_settings(&build_settings, "two");
+ Settings other_settings(&build_settings, "two/");
EXPECT_EQ("//out/Debug/two/gen/",
GetGenDirForSourceDir(&other_settings, SourceDir("//")).value());
EXPECT_EQ("//out/Debug/two/gen/foo/bar/",
« no previous file with comments | « tools/gn/filesystem_utils.cc ('k') | tools/gn/function_get_label_info.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698