Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1191)

Unified Diff: tools/gn/loader.cc

Issue 279023002: Add GN function get_label_info (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: review comment Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/gn.gyp ('k') | tools/gn/scope_per_file_provider_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/loader.cc
diff --git a/tools/gn/loader.cc b/tools/gn/loader.cc
index 885670ab80572bd1d1d5d82baec4265cc1c3c631..4cca2ce71b2805f5eeb9004a55cba0a0630c2853 100644
--- a/tools/gn/loader.cc
+++ b/tools/gn/loader.cc
@@ -19,20 +19,6 @@
#include "tools/gn/source_file.h"
#include "tools/gn/trace.h"
-namespace {
-
-std::string GetOutputSubdirName(const Label& toolchain_label, bool is_default) {
- // The default toolchain has no subdir.
- if (is_default)
- return std::string();
-
- // For now just assume the toolchain name is always a valid dir name. We may
- // want to clean up the in the future.
- return toolchain_label.name();
-}
-
-} // namespace
-
// Identifies one time a file is loaded in a given toolchain so we don't load
// it more than once.
struct LoaderImpl::LoadID {
« no previous file with comments | « tools/gn/gn.gyp ('k') | tools/gn/scope_per_file_provider_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698