DescriptionReland of Bug Fix: Data Race For WebMediaPlayerMS' Frame Count Variable (patchset #1 id:1 of https://codereview.chromium.org/2777183009/ )
Reason for revert:
By testing, this CL is not the cause of increase of chrome_public_test_apk run time.
Original issue's description:
> Revert of Bug Fix: Data Race For WebMediaPlayerMS' Frame Count Variable (patchset #3 id:60001 of https://codereview.chromium.org/2751353003/ )
>
> Reason for revert:
> Lock contention, increase chrome_public_test_apk run time a lot.
>
> We might need a finer lock.
>
> Original issue's description:
> > Bug Fix: Data Race For WebMediaPlayerMS' Frame Count Variable
> >
> > On thread sanitizer, we found a data race issue for WebMediaPlayerMS' frame
> > count variables |total_frame_count_| and |dropped_frame_count_|. In this CL
> > We make those two variables atomic.
> >
> > BUG=701712
> >
> > Review-Url: https://codereview.chromium.org/2751353003
> > Cr-Commit-Position: refs/heads/master@{#457786}
> > Committed: https://chromium.googlesource.com/chromium/src/+/4cb6dcab2e3d9b4f14ff3bd5dc8f3fd3a57e19e5
>
> TBR=dalecurtis@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=701712
>
> Review-Url: https://codereview.chromium.org/2777183009
> Cr-Commit-Position: refs/heads/master@{#460556}
> Committed: https://chromium.googlesource.com/chromium/src/+/5591e262e49dfbf3f23ad6e54717e9dcd2771fe3
TBR=dalecurtis@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=701712
Review-Url: https://codereview.chromium.org/2789973002
Cr-Commit-Position: refs/heads/master@{#461555}
Committed: https://chromium.googlesource.com/chromium/src/+/278b26a717794d67f361145e0a4a72a758839d8a
Patch Set 1 #
Messages
Total messages: 15 (9 generated)
|