Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 2789973002: Reland of Bug Fix: Data Race For WebMediaPlayerMS' Frame Count Variable (Closed)

Created:
3 years, 8 months ago by qiangchen
Modified:
3 years, 8 months ago
Reviewers:
DaleCurtis
CC:
chfremer+watch_chromium.org, chromium-reviews, darin-cc_chromium.org, feature-media-reviews_chromium.org, jam, mcasas+watch+vc_chromium.org, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Bug Fix: Data Race For WebMediaPlayerMS' Frame Count Variable (patchset #1 id:1 of https://codereview.chromium.org/2777183009/ ) Reason for revert: By testing, this CL is not the cause of increase of chrome_public_test_apk run time. Original issue's description: > Revert of Bug Fix: Data Race For WebMediaPlayerMS' Frame Count Variable (patchset #3 id:60001 of https://codereview.chromium.org/2751353003/ ) > > Reason for revert: > Lock contention, increase chrome_public_test_apk run time a lot. > > We might need a finer lock. > > Original issue's description: > > Bug Fix: Data Race For WebMediaPlayerMS' Frame Count Variable > > > > On thread sanitizer, we found a data race issue for WebMediaPlayerMS' frame > > count variables |total_frame_count_| and |dropped_frame_count_|. In this CL > > We make those two variables atomic. > > > > BUG=701712 > > > > Review-Url: https://codereview.chromium.org/2751353003 > > Cr-Commit-Position: refs/heads/master@{#457786} > > Committed: https://chromium.googlesource.com/chromium/src/+/4cb6dcab2e3d9b4f14ff3bd5dc8f3fd3a57e19e5 > > TBR=dalecurtis@chromium.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=701712 > > Review-Url: https://codereview.chromium.org/2777183009 > Cr-Commit-Position: refs/heads/master@{#460556} > Committed: https://chromium.googlesource.com/chromium/src/+/5591e262e49dfbf3f23ad6e54717e9dcd2771fe3 TBR=dalecurtis@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=701712 Review-Url: https://codereview.chromium.org/2789973002 Cr-Commit-Position: refs/heads/master@{#461555} Committed: https://chromium.googlesource.com/chromium/src/+/278b26a717794d67f361145e0a4a72a758839d8a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M content/renderer/media/webmediaplayer_ms_compositor.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/media/webmediaplayer_ms_compositor.cc View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
qiangchen
Created Reland of Bug Fix: Data Race For WebMediaPlayerMS' Frame Count Variable
3 years, 8 months ago (2017-03-31 23:04:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2789973002/1
3 years, 8 months ago (2017-03-31 23:04:46 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/419946)
3 years, 8 months ago (2017-04-01 00:19:11 UTC) #5
DaleCurtis
lgtm
3 years, 8 months ago (2017-04-03 19:13:04 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2789973002/1
3 years, 8 months ago (2017-04-03 22:05:47 UTC) #12
commit-bot: I haz the power
3 years, 8 months ago (2017-04-03 22:14:52 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/278b26a717794d67f361145e0a4a...

Powered by Google App Engine
This is Rietveld 408576698